Add JSDoc types to internal scripts#5305
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#script-typesNotice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly. or load it into the REPL: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5305 +/- ##
=======================================
Coverage 98.82% 98.82%
=======================================
Files 232 232
Lines 8974 8974
Branches 2338 2338
=======================================
Hits 8869 8869
Misses 46 46
Partials 59 59 ☔ View full report in Codecov by Sentry. |
|
This PR has been released as part of rollup@4.9.2. You can test it via |
…mismatch This reverts commit 0a7aeb8 (chore: commit package-lock.json). Reason: Vercel deploy of HEAD 826bfc2 failed immediately after the lockfile landed. Before that commit Vercel was running `npm install` (loose); with a lockfile present it switches to `npm ci` (strict), and the lockfile generated on Windows pins @rollup/rollup-win32-x64-msvc as the platform-specific optional dep. On Vercel's Linux builder `npm ci` then has no entry for @rollup/rollup-linux-x64-gnu to install, and rollup throws the classic "Cannot find module @rollup/rollup-*" error — see npm/cli#4828 and rollup/rollup#5305. Removing the lockfile restores the pre-826bfc2 working state immediately. Re-introducing a lockfile is tracked as follow-up: the prerequisites are (a) resolve the "*" version ranges and the duplicate vite entry in package.json, and (b) regenerate package-lock.json inside a Linux environment (WSL / Docker / CI) so the optional Rollup binaries captured match production. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This adds (strict) JSDocs types to all scripts in the
scriptsfolder. This will hopefully help as I want to add some scripts to generate AST transformation code to ensure that encoders and decoders are always synced.