Skip to content

docs(json): correct minimatch to picomatch#1332

Merged
shellscape merged 1 commit intorollup:masterfrom
sapphi-red:chore-json-minimatch-docs
Nov 27, 2022
Merged

docs(json): correct minimatch to picomatch#1332
shellscape merged 1 commit intorollup:masterfrom
sapphi-red:chore-json-minimatch-docs

Conversation

@sapphi-red
Copy link
Contributor

Rollup Plugin Name: json

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

plugin-json now uses pluginutils@^5.0.1 that uses picomatch instead of minimatch (previously: ^3.0.8).
I updated document from "minimatch pattern" to "picomatch pattern". Since they have a slightly different behavior.

Related: #1260

@shellscape
Copy link
Collaborator

thanks!

@shellscape shellscape merged commit 5250b88 into rollup:master Nov 27, 2022
@sapphi-red sapphi-red deleted the chore-json-minimatch-docs branch November 29, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants