fix(commonjs): crawl dynamicRequireRoot outside cwd#1859
Merged
lukastaegert merged 2 commits intorollup:masterfrom Jun 14, 2025
Merged
fix(commonjs): crawl dynamicRequireRoot outside cwd#1859lukastaegert merged 2 commits intorollup:masterfrom
lukastaegert merged 2 commits intorollup:masterfrom
Conversation
lukastaegert
approved these changes
Jun 14, 2025
Member
lukastaegert
left a comment
There was a problem hiding this comment.
Looks good, thanks a lot!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
{commonjs}This PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
resolves #1855
Description
After switching to fdir for globbing, it was no longer possible to have dynamicRequireTargets outside cwd as fdir only crawls cwd by default. dynamicRequireTargets outside cwd is often required when using npm workspaces as packages are hoisted to the node_modules in workspace root.
dynamicRequireRoot is passed to fdir's
crawl()to fix this.