feat(migrate): add monorepo support for tsup migration script#659
Merged
sxzz merged 4 commits intorolldown:mainfrom Jan 5, 2026
Merged
feat(migrate): add monorepo support for tsup migration script#659sxzz merged 4 commits intorolldown:mainfrom
sxzz merged 4 commits intorolldown:mainfrom
Conversation
✅ Deploy Preview for tsdown ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
8dea631 to
885cf20
Compare
885cf20 to
ebaf82c
Compare
710ba4e to
ccd17b1
Compare
ebaf82c to
885cf20
Compare
sxzz
requested changes
Jan 5, 2026
Member
sxzz
left a comment
There was a problem hiding this comment.
We don't want to introduce a new dependency, so we can use tsdown-migrate [...dirs], e.g., tsdown-migrate packages/*.
sxzz
reviewed
Jan 5, 2026
885cf20 to
159ed8c
Compare
159ed8c to
3ade8f4
Compare
sxzz
reviewed
Jan 5, 2026
Member
sxzz
left a comment
There was a problem hiding this comment.
Is tinyglobby really necessary? I think shells like bash will also resolve glob patterns.
Contributor
Author
In my local, if I remove tinyglobby and rely directly on shell expansion like this, it would break support for PowerShell on Windows. const baseCwd = process.cwd()
const cwds =
dirs && dirs.length > 0
? dirs.map((d) => path.resolve(baseCwd, d))
: [baseCwd] |
Member
|
Ah... PowerShell... |
sxzz
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add monorepo support for the
tsupmigration script. If executed in the monorepo root, the script will run sequentially in the current directory and in each package directory. In all other cases, it will still run only in the specified directory.Linked Issues
Resolves #452
Additional context
The testing fixtures of this PR might not be in the best shape. Need comment.