Skip to content

fix: pin rolldown version#553

Merged
sxzz merged 1 commit intomainfrom
ocavue/dont-use-latest
Oct 20, 2025
Merged

fix: pin rolldown version#553
sxzz merged 1 commit intomainfrom
ocavue/dont-use-latest

Conversation

@ocavue
Copy link
Copy Markdown
Collaborator

@ocavue ocavue commented Oct 20, 2025

Description

tsdown depends on rolldown@latest. One of the reasons is that we cannot set something like rolldown@^1.0.0-beta.44.

source

yarn add -D rolldown@^1.0.0-beta.30 installs 1.0.0-beta.9-commit.d91dfb5

However, depending on rolldown@latest causes issues for projects using pnpm. Let's say I have a project with tsdown@0.15.7 and rolldown@1.0.0-beta.43 installed. Running pnpm add is-even will also bump rolldown to the latest 1.0.0-beta.44. This is not my intention, and the unintentional update of rolldown may lead to unexpected issues. An example of this issue can be found at #551, where the new deprecated warning in the console reportedly causes "our tooling to fail."

To resolve the above two issues, we need to explicitly set the rolldown version (without the ^ prefix).

{
  "dependencies": {
    "rolldown": "1.0.0-beta.44"
  }
}

Once rolldown release 1.0.0, we don't need this anymore. We can just set "rolldown": "^1.0.0" normally.

Linked Issues

Closes #500

Additional context

@netlify
Copy link
Copy Markdown

netlify bot commented Oct 20, 2025

Deploy Preview for tsdown ready!

Name Link
🔨 Latest commit cc684ba
🔍 Latest deploy log https://app.netlify.com/projects/tsdown/deploys/68f61b6a677a0600089a5405
😎 Deploy Preview https://deploy-preview-553--tsdown.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Oct 20, 2025

Open in StackBlitz

npm i https://pkg.pr.new/tsdown@553
npm i https://pkg.pr.new/create-tsdown@553

commit: cc684ba

@ocavue ocavue marked this pull request as ready for review October 20, 2025 11:10
@ocavue ocavue requested a review from sxzz October 20, 2025 11:10
@ocavue ocavue changed the title fix: explicitly set rolldown version range fix: pin rolldown version Oct 20, 2025
@ocavue ocavue force-pushed the ocavue/dont-use-latest branch from 274e149 to cc684ba Compare October 20, 2025 11:22
@sxzz sxzz merged commit 7752efc into main Oct 20, 2025
15 checks passed
@sxzz sxzz deleted the ocavue/dont-use-latest branch October 20, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rolldown dependency is always latest

2 participants