Conversation
✅ Deploy Preview for tsdown ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
274e149 to
cc684ba
Compare
sxzz
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
tsdowndepends onrolldown@latest. One of the reasons is that we cannot set something likerolldown@^1.0.0-beta.44.However, depending on
rolldown@latestcauses issues for projects usingpnpm. Let's say I have a project withtsdown@0.15.7androlldown@1.0.0-beta.43installed. Runningpnpm add is-evenwill also bumprolldownto the latest1.0.0-beta.44. This is not my intention, and the unintentional update ofrolldownmay lead to unexpected issues. An example of this issue can be found at #551, where the new deprecated warning in the console reportedly causes "our tooling to fail."To resolve the above two issues, we need to explicitly set the
rolldownversion (without the^prefix).{ "dependencies": { "rolldown": "1.0.0-beta.44" } }Once
rolldownrelease1.0.0, we don't need this anymore. We can just set"rolldown": "^1.0.0"normally.Linked Issues
Closes #500
Additional context