fix: remove node protocol for internal polyfill

sxzz · sxzz · commit 5a61895867be · 2025-05-29T23:48:56.000+08:00
closes #276
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml
@@ -38,7 +38,7 @@ catalogs:
     diff: ^8.0.2
     empathic: ^1.1.0
     hookable: ^5.5.3
-    rolldown: 1.0.0-beta.9-commit.273d50e
+    rolldown: https://pkg.pr.new/rolldown@c7d1545
     rolldown-plugin-dts: ^0.13.5
     semver: ^7.7.2
     tinyexec: ^1.0.1
diff --git a/src/features/external.ts b/src/features/external.ts
@@ -1,3 +1,4 @@
+import { isBuiltin } from 'node:module'
 import Debug from 'debug'
 import { toArray } from '../utils/general'
 import type { ResolvedOptions } from '../options'
@@ -42,7 +43,12 @@ export function ExternalPlugin(options: ResolvedOptions): Plugin {
 
       if (shouldExternal) {
         debug('External dependency:', id)
-        return { id, external: shouldExternal }
+        return {
+          id,
+          external: shouldExternal,
+          moduleSideEffects:
+            id.startsWith('node:') || isBuiltin(id) ? false : undefined,
+        }
       }
     },
   }
diff --git a/tests/__snapshots__/remove-node-protocol-for-require-polyfill.snap.md b/tests/__snapshots__/remove-node-protocol-for-require-polyfill.snap.md
@@ -0,0 +1,15 @@
+## index.js
+
+```js
+import { createRequire } from "module";
+
+//#region rolldown:runtime
+var __require = /* @__PURE__ */ createRequire(import.meta.url);
+
+//#endregion
+//#region index.ts
+const fn = __require.resolve;
+
+//#endregion
+export { fn };
+```
diff --git a/tests/index.test.ts b/tests/index.test.ts
@@ -322,6 +322,20 @@ test('remove node protocol', async (context) => {
   expect(snapshot).not.contains('node:')
 })
 
+test('remove node protocol for require polyfill', async (context) => {
+  const files = {
+    'index.ts': `export const fn = require.resolve`,
+  }
+  const { snapshot } = await testBuild({
+    context,
+    files,
+    options: {
+      removeNodeProtocol: true,
+    },
+  })
+  expect(snapshot).not.contains('node:')
+})
+
 test('without hash and filename conflict', async (context) => {
   const files = {
     'index.ts': `
