feat: add abort controller for onSuccess (#282)

sebasptsch · web-flow · commit 4db2046b1211 · 2025-05-30T10:50:12.000Z
diff --git a/src/index.ts b/src/index.ts
@@ -99,7 +99,7 @@ export async function buildSingle(
   clean: () => Promise<void>,
 ): Promise<(() => Promise<void>) | undefined> {
   const { format: formats, dts, watch, onSuccess } = config
-  let onSuccessCleanup: (() => any) | undefined
+  let ab: AbortController | undefined
 
   const { hooks, context } = await createHooks(config)
 
@@ -112,7 +112,7 @@ export async function buildSingle(
     const startTime = performance.now()
 
     await hooks.callHook('build:prepare', context)
-    onSuccessCleanup?.()
+    ab?.abort()
 
     await clean()
 
@@ -165,19 +165,19 @@ export async function buildSingle(
       prettyName(config.name),
       `${first ? 'Build' : 'Rebuild'} complete in ${green(`${Math.round(performance.now() - startTime)}ms`)}`,
     )
-
+    ab = new AbortController()
     if (typeof onSuccess === 'string') {
       const p = exec(onSuccess, [], {
         nodeOptions: { shell: true, stdio: 'inherit' },
+        signal: ab.signal,
       })
       p.then(({ exitCode }) => {
         if (exitCode) {
           process.exitCode = exitCode
         }
       })
-      onSuccessCleanup = () => p.kill('SIGTERM')
     } else {
-      await onSuccess?.(config)
+      await onSuccess?.(config, ab.signal)
     }
   }
 }
diff --git a/src/options/types.ts b/src/options/types.ts
@@ -228,7 +228,7 @@ export interface Options {
   /**
    * You can specify command to be executed after a successful build, specially useful for Watch mode
    */
-  onSuccess?: string | ((config: ResolvedOptions) => void | Promise<void>)
+  onSuccess?: string | ((config: ResolvedOptions, signal: AbortSignal) => void | Promise<void>)
 
   /**
    * Skip bundling `node_modules`.
