fix: upgrade rolldown, fix dts comment & banner

sxzz · sxzz · commit 2af8cbb98a1f · 2025-09-12T23:47:15.000+09:00
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "tsdown",
   "version": "0.15.0",
-  "packageManager": "pnpm@10.15.1",
+  "packageManager": "pnpm@10.16.0",
   "description": "The Elegant Bundler for Libraries",
   "type": "module",
   "license": "MIT",
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml
@@ -37,9 +37,9 @@ catalogs:
     vite: npm:rolldown-vite@latest
     vitepress: ^2.0.0-alpha.12
     vitepress-plugin-group-icons: ^1.6.3
-    vitepress-plugin-llms: ^1.7.4
+    vitepress-plugin-llms: ^1.7.5
     vue: ^3.5.21
-    vue-tsc: ^3.0.6
+    vue-tsc: ^3.0.7
 
   prod:
     ansis: ^4.1.0
@@ -50,7 +50,7 @@ catalogs:
     empathic: ^2.0.0
     hookable: ^5.5.3
     rolldown: latest
-    rolldown-plugin-dts: ^0.16.2
+    rolldown-plugin-dts: ^0.16.5
     semver: ^7.7.2
     tinyexec: ^1.0.1
     tinyglobby: ^0.2.15
diff --git a/src/features/output.ts b/src/features/output.ts
@@ -90,18 +90,29 @@ export interface ChunkAddonObject {
 }
 export type ChunkAddonFunction = (ctx: {
   format: Format
-}) => ChunkAddonObject | undefined
-export type ChunkAddon = ChunkAddonObject | ChunkAddonFunction
+  fileName: string
+}) => ChunkAddonObject | string | undefined
+export type ChunkAddon = ChunkAddonObject | ChunkAddonFunction | string
 
 export function resolveChunkAddon(
   chunkAddon: ChunkAddon | undefined,
   format: NormalizedFormat,
+  dts?: boolean,
 ): AddonFunction | undefined {
   if (!chunkAddon) return
 
   return (chunk: RenderedChunk) => {
+    if (!dts && RE_DTS.test(chunk.fileName)) return ''
+
     if (typeof chunkAddon === 'function') {
-      chunkAddon = chunkAddon({ format })
+      chunkAddon = chunkAddon({
+        format,
+        fileName: chunk.fileName,
+      })
+    }
+
+    if (typeof chunkAddon === 'string') {
+      return chunkAddon
     }
 
     switch (true) {
diff --git a/src/features/rolldown.ts b/src/features/rolldown.ts
@@ -85,6 +85,8 @@ export async function resolveInputOptions(
     name,
     logger,
     cjsDefault,
+    banner,
+    footer,
   } = config
 
   const plugins: RolldownPluginOption = []
@@ -99,7 +101,12 @@ export async function resolveInputOptions(
 
   if (dts) {
     const { dts: dtsPlugin } = await import('rolldown-plugin-dts')
-    const options: DtsOptions = { tsconfig, ...dts }
+    const options: DtsOptions = {
+      tsconfig,
+      banner: resolveChunkAddon(banner, format, true),
+      footer: resolveChunkAddon(footer, format, true),
+      ...dts,
+    }
 
     if (format === 'es') {
       plugins.push(dtsPlugin(options))
diff --git a/tests/__snapshots__/banner-and-footer-option.snap.md b/tests/__snapshots__/banner-and-footer-option.snap.md
@@ -2,7 +2,7 @@
 
 ```ts
 // dts banner
-export {};
+export { };
 // dts footer
 ```
 ## index.js
diff --git a/tests/__snapshots__/issues/206.snap.md b/tests/__snapshots__/issues/206.snap.md
@@ -2,7 +2,6 @@
 
 ```ts
 export * from "pkg1";
-export {};
 ```
 ## index.js
 
diff --git a/tests/__snapshots__/issues/61.snap.md b/tests/__snapshots__/issues/61.snap.md
@@ -5,23 +5,23 @@ import * as debug from "debug";
 
 //#region rolldown:runtime
 var __defProp = Object.defineProperty;
-var __export = (target, all) => {
+var __export = (all) => {
+	let target = {};
 	for (var name in all) __defProp(target, name, {
 		get: all[name],
 		enumerable: true
 	});
+	return target;
 };
 
 //#endregion
 //#region src/foo.ts
-var foo_exports = {};
-__export(foo_exports, { foo: () => foo });
+var foo_exports = __export({ foo: () => foo });
 const foo = 1;
 
 //#endregion
 //#region bar.ts
-var bar_exports = {};
-__export(bar_exports, { bar: () => bar });
+var bar_exports = __export({ bar: () => bar });
 const bar = 2;
 
 //#endregion
diff --git a/tests/__snapshots__/resolve-dependency-for-dts.snap.md b/tests/__snapshots__/resolve-dependency-for-dts.snap.md
@@ -18,12 +18,6 @@ type Options = {
   */
   last?: string;
 };
-/**
-* Get all parent directories of {@link base}.
-* Stops after {@link Options['last']} is processed.
-*
-* @returns An array of absolute paths of all parent directories.
-*/
 export { type Options };
 ```
 ## index.js

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "tsdown",`
`3`	`3`	`"version": "0.15.0",`
`4`		`- "packageManager": "pnpm@10.15.1",`
	`4`	`+ "packageManager": "pnpm@10.16.0",`
`5`	`5`	`"description": "The Elegant Bundler for Libraries",`
`6`	`6`	`"type": "module",`
`7`	`7`	`"license": "MIT",`