Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
✅ Deploy Preview for rolldown-rs canceled.
|
Member
|
Some notes:
|
a0cf672 to
9cff683
Compare
| NPM_CONFIG_PROVENANCE: true | ||
|
|
||
| release: | ||
| needs: [check, release] |
Contributor
There was a problem hiding this comment.
There appears to be a circular dependency in the job configuration. The release job lists itself in its own needs array:
needs: [check, release]This creates a circular reference that will prevent the workflow from executing properly. Consider changing this to only depend on the check job, or reference a different job name if another job should be completed before this one runs.
Suggested change
| needs: [check, release] | |
| needs: [check] |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Boshen
pushed a commit
that referenced
this pull request
Jun 7, 2025
## [1.0.0-beta.13] - 2025-06-07 ### 🚀 Features - feat: merge same `ImportNamespaceSpecifier` for external module by @IWANABETHATGUY in [#4373](#4373) ### 🐛 Bug Fixes - ci: disable `generate_release_notes` by @Boshen ### 📚 Documentation - docs: add MAINTENANCE.md; remove rolldown.rs/contrib-guide/release by @Boshen in [#4854](#4854) ### ⚙️ Miscellaneous Tasks - add input description to prepare-release.yml by @Boshen - fix prepare-release.yml by @Boshen - CHANGELOG.md: ci(CHANGELOG.md): use git-cliff to generate changelogs by @Boshen in [#4858](#4858)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the npm package
conventional-changelogin favor of git cliff, which produces cleaner changelog, and is more powerful and easier to use.changelog is also added to the release PR and github release.
CHANGELOG.md is regenerated.