Skip to content

docs(contrib-guide): mention that running tests on older Node.js version will have different stat results#8996

Merged
sapphi-red merged 5 commits into
mainfrom
claude/update-contribution-guide-node-versions
Apr 3, 2026
Merged

docs(contrib-guide): mention that running tests on older Node.js version will have different stat results#8996
sapphi-red merged 5 commits into
mainfrom
claude/update-contribution-guide-node-versions

Conversation

@Claude

@Claude Claude AI commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@netlify

netlify Bot commented Apr 3, 2026

Copy link
Copy Markdown

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 9b3f81b
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/69cf86912219b300088cb395
😎 Deploy Preview https://deploy-preview-8996--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Claude Claude AI changed the title [WIP] Update contribution guide for node version compatibility docs: document Node version compatibility in Rollup test suite Apr 3, 2026
@Claude Claude AI requested a review from sapphi-red April 3, 2026 08:19
@sapphi-red

Copy link
Copy Markdown
Member

@claude[agent] keep it concise. only mention that the value would be different unless the version isn't higher than ...

@Claude

Claude AI commented Apr 3, 2026

Copy link
Copy Markdown
Contributor Author

@claude[agent] keep it concise. only mention that the value would be different unless the version isn't higher than ...

Made it more concise. The section now simply states that test counts will differ unless Node version is 24 or higher. (5247f3f)

@Claude Claude AI changed the title docs: document Node version compatibility in Rollup test suite Addressing PR comments Apr 3, 2026
@sapphi-red

Copy link
Copy Markdown
Member

@claude[agent] use a > [!NOTE] block instead of a separate section

@Claude

Claude AI commented Apr 3, 2026

Copy link
Copy Markdown
Contributor Author

@claude[agent] use a > [!NOTE] block instead of a separate section

Converted to a NOTE block. (bc138d2)

Comment thread docs/development-guide/testing.md Outdated
Signed-off-by: 翠 <green@sapphi.red>
@sapphi-red sapphi-red changed the title Addressing PR comments docs(contrib-guide): mention that running tests on older Node.js version will have different stat results Apr 3, 2026
@sapphi-red sapphi-red marked this pull request as ready for review April 3, 2026 09:24
@sapphi-red sapphi-red added the documentation Improvements or additions to documentation label Apr 3, 2026
@sapphi-red sapphi-red merged commit 2280eb2 into main Apr 3, 2026
35 of 36 checks passed
@sapphi-red sapphi-red deleted the claude/update-contribution-guide-node-versions branch April 3, 2026 09:24
@github-actions github-actions Bot mentioned this pull request Apr 8, 2026
@github-actions github-actions Bot mentioned this pull request Apr 8, 2026
shulaoda added a commit that referenced this pull request Apr 8, 2026
## [1.0.0-rc.14] - 2026-04-08

### 🚀 Features

- rust: add `disable_panic_hook` feature to disable the panic hook (#9023) by @sapphi-red
- support inlineConst for CJS exports accessed through module.exports (#8976) by @h-a-n-a

### 🐛 Bug Fixes

- rolldown_plugin_vite_import_glob: normalize resolved alias path to prevent double slashes (#9032) by @shulaoda
- rolldown_plugin_vite_import_glob: follow symlinks in file scanning (#9000) by @Copilot
- wrap CJS entry modules for IIFE/UMD when using exports/module (#8999) by @IWANABETHATGUY
- emit separate __toESM bindings for mixed ESM/CJS external imports (#8987) by @IWANABETHATGUY
- tree-shake dead dynamic imports to side-effect-free CJS modules (#8529) by @sapphi-red
- skip inlining stale CJS export constants on module.exports reassignment (#8990) by @IWANABETHATGUY

### 🚜 Refactor

- generator: migrate ecma formatting from npx oxfmt to vp fmt (#9022) by @shulaoda
- generator: replace npx oxfmt with vp fmt for ecma formatting (#9021) by @shulaoda

### 📚 Documentation

- contrib-guide: mention that running tests on older Node.js version will have different stat results (#8996) by @claude

### ⚙️ Miscellaneous Tasks

- deps: update npm packages (#9002) by @renovate[bot]
- deps: update dependency @napi-rs/cli to v3.6.1 (#9034) by @renovate[bot]
- deps: upgrade oxc to 0.124.0 (#9018) by @shulaoda
- deps: update test262 submodule for tests (#9010) by @sapphi-red
- deps: update dependency oxfmt to ^0.44.0 (#9012) by @renovate[bot]
- deps: update dependency vite to v8.0.5 [security] (#9009) by @renovate[bot]
- deps: update dependency vite-plus to v0.1.16 (#9008) by @renovate[bot]
- deps: update rust crates (#9003) by @renovate[bot]
- deps: update github-actions (#9004) by @renovate[bot]
- deps: update dependency lodash-es to v4.18.1 [security] (#8992) by @renovate[bot]
- deps: update crate-ci/typos action to v1.45.0 (#8988) by @renovate[bot]
- upgrade oxc npm packages to 0.123.0 (#8985) by @shulaoda

### ◀️ Revert

- "chore(deps): update dependency oxfmt to ^0.44.0 (#9012)" (#9019) by @shulaoda

Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: The number of passed tests does not match because of node version is incompatible

2 participants