fix: use sanitized filename for preserve modules chunk name by IWANABETHATGUY · Pull Request #7603 · rolldown/rolldown

IWANABETHATGUY · 2025-12-20T10:12:38Z

IWANABETHATGUY · 2025-12-20T10:12:53Z

fix: use sanitized filename for preserve modules chunk name #7603 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2025-12-20T10:14:14Z

✅ Deploy Preview for rolldown-rs ready!

Name	Link
🔨 Latest commit	`c6babdd`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/6946f22584c8f5000884e3d5
😎 Deploy Preview	https://deploy-preview-7603--rolldown-rs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

pkg-pr-new · 2025-12-20T10:32:13Z

Open in StackBlitz

@rolldown/browser

npm i https://pkg.pr.new/@rolldown/browser@7603

@rolldown/debug

npm i https://pkg.pr.new/@rolldown/debug@7603

@rolldown/pluginutils

npm i https://pkg.pr.new/@rolldown/pluginutils@7603

rolldown

npm i https://pkg.pr.new/rolldown@7603

@rolldown/binding-android-arm64

npm i https://pkg.pr.new/@rolldown/binding-android-arm64@7603

@rolldown/binding-darwin-arm64

npm i https://pkg.pr.new/@rolldown/binding-darwin-arm64@7603

@rolldown/binding-darwin-x64

npm i https://pkg.pr.new/@rolldown/binding-darwin-x64@7603

@rolldown/binding-freebsd-x64

npm i https://pkg.pr.new/@rolldown/binding-freebsd-x64@7603

@rolldown/binding-linux-arm-gnueabihf

npm i https://pkg.pr.new/@rolldown/binding-linux-arm-gnueabihf@7603

@rolldown/binding-linux-arm64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-gnu@7603

@rolldown/binding-linux-arm64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-musl@7603

@rolldown/binding-linux-x64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-gnu@7603

@rolldown/binding-linux-x64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-musl@7603

@rolldown/binding-openharmony-arm64

npm i https://pkg.pr.new/@rolldown/binding-openharmony-arm64@7603

@rolldown/binding-wasm32-wasi

npm i https://pkg.pr.new/@rolldown/binding-wasm32-wasi@7603

@rolldown/binding-win32-arm64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-arm64-msvc@7603

@rolldown/binding-win32-x64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-x64-msvc@7603

commit: ddfa74e

graphite-app · 2025-12-20T18:59:34Z

Merge activity

Dec 20, 6:59 PM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Dec 20, 7:09 PM UTC: Merged by the Graphite merge queue.

closed #7554

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

closed #7554

@sapphi-red

## [1.0.0-beta.56] - 2025-12-22 ### 💥 BREAKING CHANGES - rename `MIXED_EXPORT` error to `MIXED_EXPORTS` (#7565) by @sapphi-red ### 🚀 Features - rename `id` property to `exporter` in CIRCULAR_REEXPORT error (#7592) by @sapphi-red - add `ids` property to `CIRCULAR_DEPENDENCY` error (#7591) by @sapphi-red - node/dev: expose `devMode.lazy` (#7549) by @hyf0 - set log and pos properties for `parseAst` function errors (#7568) by @sapphi-red - set log and pos properties for logs (#7567) by @sapphi-red - test-dev-sever: support to manually configure port, run tests in concurrent (#7576) by @hyf0 - add `exporter` property to `MISSING_EXPORT` error (#7564) by @sapphi-red - add `id` property to `PARSE_ERROR` error (#7563) by @sapphi-red - support ImporterId hook filter (#7540) by @IWANABETHATGUY ### 🐛 Bug Fixes - types: better "go to definition" experience for interface `OutputPlugin` (#7610) by @KazariEX - `postBanner` content should be placed after shebang (#7583) by @btea - use sanitized filename for preserve modules chunk name (#7603) by @IWANABETHATGUY - correct filter out unused cjs namespace (#7602) by @IWANABETHATGUY - watch: property respect `notify.pollInternal` and `notify.compareContents` (#7595) by @sapphi-red - make `cleanDir` work with default output directory (#7579) by @shulaoda - merge `MISSING_NAME_OPTION_FOR_UMD_EXPORT` error to `MISSING_NAME_OPTION_FOR_IIFE_EXPORT` error (#7566) by @sapphi-red - dev/hmr: ensure cjs modules with no exports reference correct `module` identifier (#7544) by @leegeunhyeok ### 🚜 Refactor - remove `stable_id` field from `PARSE_ERROR` error (#7593) by @sapphi-red - make include_runtime_symbol reuseable after linking stage (#7580) by @IWANABETHATGUY - rust/dev: construct the bundler within itself (#7553) by @hyf0 - rust/watcher: polish API of `Watcher` struct (#7551) by @hyf0 - use `LinkingMetadata::stmt_info_included` to check if a stmt_info is included (#7572) by @IWANABETHATGUY - use `LinkingMetadata::is_included` to check if a module is included (#7571) by @IWANABETHATGUY - store module and stmt_info is included info to module meta (#7570) by @IWANABETHATGUY - make include_* method reunsable after linking stage (#7552) by @IWANABETHATGUY - rust/watcher: construct the bundler within watcher itself (#7550) by @hyf0 - extract make include_runtime_symbol reusable (#7546) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - renovate: add `kill-port` in `ignoreDeps` in renovate.json (#7619) by @sapphi-red - deps: update rust crates (#7617) by @renovate[bot] - deps: update npm packages (#7616) by @renovate[bot] - deps: update github-actions (#7615) by @renovate[bot] - ci: skip benchmark workflows on draft PRs (#7611) by @Copilot - deps: update dependency rolldown-plugin-dts to ^0.19.0 (#7607) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.10.0 (#7601) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.18.4 (#7599) by @renovate[bot] - deps: update notify (#7594) by @sapphi-red - test-dev-server: add retry mechanism to hmr-full-bundle-mode tests (#7588) by @Copilot - deps: update napi to v3.7.1 (#7590) by @renovate[bot] - add JSDoc documentation for memfs type (#7587) by @Copilot - deps: update dependency oxlint to v1.34.0 (#7589) by @renovate[bot] - move some tests in ignored-by-unsupported-features that are passing (#7569) by @sapphi-red - deps: update dependency oxlint-tsgolint to v0.9.2 (#7582) by @renovate[bot] - deps: update oxc resolver to v11.16.0 (#7574) by @renovate[bot] - test/dev-server: don't run `pnpm install` during tests (#7560) by @hyf0 - test/dev-server: use `kill-port@1` to improve performance (#7575) by @hyf0 - normalize error object to make some Rollup tests pass (#7562) by @sapphi-red - ci: separate dev-server(hmr) tests and normal tests (#7558) by @hyf0 - ci: make native rolldown build reusable (#7557) by @hyf0 - resolve some TODOs (#7561) by @sapphi-red ### ❤️ New Contributors * @KazariEX made their first contribution in [#7610](#7610) * @leegeunhyeok made their first contribution in [#7544](#7544) Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>

github-actions Bot assigned IWANABETHATGUY Dec 20, 2025

IWANABETHATGUY force-pushed the 12-20-fix_7554 branch from 55c87d3 to ddfa74e Compare December 20, 2025 10:14

IWANABETHATGUY commented Dec 20, 2025

View reviewed changes

Comment thread packages/rolldown/tests/fixtures/topics/preserve-modules/sanitize-filename/_config.ts

IWANABETHATGUY added the trigger: preview label Dec 20, 2025

IWANABETHATGUY force-pushed the 12-20-fix_7554 branch 2 times, most recently from 2ead136 to c868942 Compare December 20, 2025 10:23

IWANABETHATGUY marked this pull request as ready for review December 20, 2025 12:32

Copilot AI review requested due to automatic review settings December 20, 2025 12:32

Copilot started reviewing on behalf of IWANABETHATGUY December 20, 2025 12:33 View session

IWANABETHATGUY changed the title ~~fix: 7554~~ fix: use sanitized filename for preserve modules chunk name Dec 20, 2025

IWANABETHATGUY requested review from sapphi-red and removed request for Copilot December 20, 2025 12:34

hyf0 approved these changes Dec 20, 2025

View reviewed changes

fix: use sanitized filename for preserve modules chunk name (#7603)

c6babdd

closed #7554

graphite-app Bot force-pushed the 12-20-fix_7554 branch from c868942 to c6babdd Compare December 20, 2025 18:59

Copilot AI review requested due to automatic review settings December 20, 2025 18:59

Copilot AI reviewed Dec 20, 2025

graphite-app Bot merged commit c6babdd into main Dec 20, 2025
31 checks passed

graphite-app Bot deleted the 12-20-fix_7554 branch December 20, 2025 19:09

sapphi-red mentioned this pull request Dec 21, 2025

[Bug]: chunk.name passed to entryFileNames is not sanitized when preserveModules: true #7554

Closed

IWANABETHATGUY added a commit that referenced this pull request Dec 21, 2025

fix: use sanitized filename for preserve modules chunk name (#7603)

b0ed837

closed #7554

github-actions Bot mentioned this pull request Dec 22, 2025

release: v1.0.0-beta.56 #7620

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: use sanitized filename for preserve modules chunk name#7603

fix: use sanitized filename for preserve modules chunk name#7603
graphite-app[bot] merged 1 commit into
mainfrom
12-20-fix_7554

IWANABETHATGUY commented Dec 20, 2025 •

edited

Loading

Uh oh!

IWANABETHATGUY commented Dec 20, 2025

Uh oh!

netlify Bot commented Dec 20, 2025 •

edited

Loading

Uh oh!

Uh oh!

pkg-pr-new Bot commented Dec 20, 2025

Uh oh!

graphite-app Bot commented Dec 20, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

IWANABETHATGUY commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IWANABETHATGUY commented Dec 20, 2025

How to use the Graphite Merge Queue

Uh oh!

netlify Bot commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs ready!

Uh oh!

Uh oh!

pkg-pr-new Bot commented Dec 20, 2025

Uh oh!

graphite-app Bot commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

IWANABETHATGUY commented Dec 20, 2025 •

edited

Loading

netlify Bot commented Dec 20, 2025 •

edited

Loading

graphite-app Bot commented Dec 20, 2025 •

edited

Loading