Skip to content

feat(node/advance-chunks): support global fallback for minSize, minShareCount#2178

Merged
hyf0 merged 1 commit intomainfrom
09-06-feat_node_advance-chunks_support_global_fallback_for_minsize_minsharecount_
Sep 6, 2024
Merged

feat(node/advance-chunks): support global fallback for minSize, minShareCount#2178
hyf0 merged 1 commit intomainfrom
09-06-feat_node_advance-chunks_support_global_fallback_for_minsize_minsharecount_

Conversation

@hyf0
Copy link
Copy Markdown
Member

@hyf0 hyf0 commented Sep 5, 2024

Description

This was referenced Sep 5, 2024
Merged
Merged
@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Sep 5, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

@hyf0 hyf0 mentioned this pull request Sep 5, 2024
Merged
@hyf0 hyf0 marked this pull request as ready for review September 5, 2024 16:59
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 5, 2024 •
edited
Loading

Benchmarks Rust

  • target: main(3c95d30)
  • pr: 09-06-feat_node_advance-chunks_support_global_fallback_for_minsize_minsharecount_(1598064)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     60.8±1.50ms        ? ?/sec    1.00     60.8±1.10ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.01     85.2±2.59ms        ? ?/sec    1.00     84.1±1.72ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.03    106.7±1.94ms        ? ?/sec    1.00    104.1±2.69ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.01     67.8±1.46ms        ? ?/sec    1.00     67.4±0.92ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    105.8±1.13ms        ? ?/sec    1.02    108.0±1.29ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    208.0±5.57ms        ? ?/sec    1.04    216.0±5.52ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    259.3±5.77ms        ? ?/sec    1.02    265.1±6.18ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.01    123.6±2.08ms        ? ?/sec    1.00    123.0±1.63ms        ? ?/sec
bundle/bundle@threejs                                               1.00     34.6±0.21ms        ? ?/sec    1.03     35.7±1.05ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     84.1±2.37ms        ? ?/sec    1.11     93.4±3.08ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    104.5±2.64ms        ? ?/sec    1.11    116.3±3.30ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     44.2±0.31ms        ? ?/sec    1.04     46.1±0.79ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    362.3±4.12ms        ? ?/sec    1.04    376.3±3.78ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   973.6±16.16ms        ? ?/sec    1.03  1000.0±10.62ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1239.6±15.13ms        ? ?/sec    1.02  1262.0±13.80ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    428.6±4.41ms        ? ?/sec    1.04    447.6±4.97ms        ? ?/sec
remapping/remapping                                                 1.00     33.7±0.82ms        ? ?/sec    1.00     33.6±0.21ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     83.2±0.36ms        ? ?/sec    1.01     84.4±0.62ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     86.6±1.02ms        ? ?/sec    1.01     87.1±1.07ms        ? ?/sec
scan/scan@threejs                                                   1.00     27.1±0.22ms        ? ?/sec    1.00     27.2±0.82ms        ? ?/sec
scan/scan@threejs10x                                                1.00    267.3±1.82ms        ? ?/sec    1.01    268.8±2.94ms        ? ?/sec

@hyf0 hyf0 force-pushed the 09-06-feat_node_advance-chunks_support_global_fallback_for_minsize_minsharecount_ branch from c7d1c2c to d70e93c Compare September 5, 2024 17:16
@hyf0 hyf0 self-assigned this Sep 6, 2024
Base automatically changed from 09-06-feat_node_advance-chunks_support_passing_minsize_minsharecount_ to main September 6, 2024 04:06
@hyf0 hyf0 force-pushed the 09-06-feat_node_advance-chunks_support_global_fallback_for_minsize_minsharecount_ branch from d70e93c to 1598064 Compare September 6, 2024 04:06
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 6, 2024

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 1598064
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66da7fbdd559c60008ffb93c

@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Sep 6, 2024

Merge activity

  • Sep 6, 12:06 AM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@hyf0 hyf0 added this pull request to the merge queue Sep 6, 2024
Merged via the queue into main with commit 78c7750 Sep 6, 2024
@hyf0 hyf0 deleted the 09-06-feat_node_advance-chunks_support_global_fallback_for_minsize_minsharecount_ branch September 6, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@hyf0 hyf0

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hyf0