Skip to content

feat(rust/advance-chunks): support min_share_count option#2176

Merged
hyf0 merged 1 commit intomainfrom
09-06-feat_rust_advance-chunks_support_min_share_count_option
Sep 6, 2024
Merged

feat(rust/advance-chunks): support min_share_count option#2176
hyf0 merged 1 commit intomainfrom
09-06-feat_rust_advance-chunks_support_min_share_count_option

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Sep 5, 2024

Description

@hyf0 Graphite App
Copy link
Member Author

hyf0 commented Sep 5, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

@hyf0 hyf0 mentioned this pull request Sep 5, 2024
Merged
@hyf0 hyf0 marked this pull request as ready for review September 5, 2024 16:59
This was referenced Sep 5, 2024
Merged
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024 •
edited
Loading

Benchmarks Rust

  • target: main(1e9c2d9)
  • pr: 09-06-feat_rust_advance-chunks_support_min_share_count_option(2d48e99)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     51.4±0.55ms        ? ?/sec    1.01     51.8±0.89ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     73.3±0.76ms        ? ?/sec    1.04     76.4±0.64ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     90.4±0.52ms        ? ?/sec    1.05     94.9±4.13ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     59.8±1.25ms        ? ?/sec    1.01     60.6±2.07ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00     99.7±0.81ms        ? ?/sec    1.01    100.8±1.17ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    176.0±3.25ms        ? ?/sec    1.02    179.5±2.46ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    218.7±2.95ms        ? ?/sec    1.01    221.9±1.84ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    115.4±0.77ms        ? ?/sec    1.01    116.6±1.34ms        ? ?/sec
bundle/bundle@threejs                                               1.02     32.9±1.95ms        ? ?/sec    1.00     32.3±0.09ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     77.1±0.87ms        ? ?/sec    1.01     77.9±1.17ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00     96.7±1.44ms        ? ?/sec    1.01     97.5±1.42ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     41.2±0.46ms        ? ?/sec    1.02     42.0±0.53ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    349.0±1.91ms        ? ?/sec    1.01    351.6±4.05ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00    927.3±5.62ms        ? ?/sec    1.01    935.4±6.85ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   1179.7±9.65ms        ? ?/sec    1.01   1191.6±9.58ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    418.1±2.25ms        ? ?/sec    1.01    421.5±2.67ms        ? ?/sec
remapping/remapping                                                 1.01     32.3±0.15ms        ? ?/sec    1.00     32.0±0.24ms        ? ?/sec
remapping/render-chunk-remapping                                    1.01     82.3±0.40ms        ? ?/sec    1.00     81.6±0.25ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     81.0±0.66ms        ? ?/sec    1.01     81.6±1.00ms        ? ?/sec
scan/scan@threejs                                                   1.00     25.2±0.13ms        ? ?/sec    1.01     25.3±0.72ms        ? ?/sec
scan/scan@threejs10x                                                1.00    254.4±2.50ms        ? ?/sec    1.01    256.6±1.23ms        ? ?/sec

@hyf0 hyf0 self-assigned this Sep 6, 2024
Base automatically changed from 09-05-feat_rust_advance-chunks_support_min_size_option to main September 6, 2024 03:22
@hyf0 hyf0 force-pushed the 09-06-feat_rust_advance-chunks_support_min_share_count_option branch from 9f4adc9 to 2d48e99 Compare September 6, 2024 03:22
@netlify
Copy link

netlify bot commented Sep 6, 2024

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 2d48e99
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66da7590c4f0a40008326c04

@hyf0 Graphite App
Copy link
Member Author

hyf0 commented Sep 6, 2024

Merge activity

  • Sep 5, 11:23 PM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@hyf0 hyf0 added this pull request to the merge queue Sep 6, 2024
Merged via the queue into main with commit 689cbc2 Sep 6, 2024
@hyf0 hyf0 deleted the 09-06-feat_rust_advance-chunks_support_min_share_count_option branch September 6, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@hyf0 hyf0

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hyf0