Skip to content

feat(rust/advance-chunks): support min_size option#2175

Merged
hyf0 merged 1 commit intomainfrom
09-05-feat_rust_advance-chunks_support_min_size_option
Sep 6, 2024
Merged

feat(rust/advance-chunks): support min_size option#2175
hyf0 merged 1 commit intomainfrom
09-05-feat_rust_advance-chunks_support_min_size_option

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Sep 5, 2024

Description

@hyf0 hyf0 marked this pull request as ready for review September 5, 2024 13:56
@hyf0 Graphite App
Copy link
Member Author

hyf0 commented Sep 5, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

@netlify
Copy link

netlify bot commented Sep 5, 2024 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 5263279
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66d9bb09f8e2440008800fdd

@hyf0 hyf0 force-pushed the 09-05-feat_rust_advance-chunks_support_min_size_option branch from bf1450c to 8d738cf Compare September 5, 2024 13:57
@hyf0 hyf0 force-pushed the 09-05-feat_rust_advance-chunks_support_min_size_option branch from 8d738cf to 5263279 Compare September 5, 2024 14:07
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Benchmarks Rust

  • target: main(11269d4)
  • pr: 09-05-feat_rust_advance-chunks_support_min_size_option(5263279)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.02     54.5±1.60ms        ? ?/sec    1.00     53.5±2.40ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     75.7±0.84ms        ? ?/sec    1.01     76.4±1.27ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     93.6±1.50ms        ? ?/sec    1.03     96.2±1.41ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.01     62.1±1.28ms        ? ?/sec    1.00     61.4±1.31ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    101.2±1.19ms        ? ?/sec    1.00    101.5±1.50ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.04    185.0±3.68ms        ? ?/sec    1.00    178.5±3.24ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.04    232.0±5.97ms        ? ?/sec    1.00    222.1±7.47ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    116.2±0.90ms        ? ?/sec    1.00    116.7±1.12ms        ? ?/sec
bundle/bundle@threejs                                               1.05     36.2±3.73ms        ? ?/sec    1.00     34.5±0.77ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     82.7±1.96ms        ? ?/sec    1.04     86.2±2.41ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    101.2±1.12ms        ? ?/sec    1.03    104.4±2.07ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     43.2±0.43ms        ? ?/sec    1.02     44.0±0.65ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    360.9±3.58ms        ? ?/sec    1.03    372.0±6.41ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   971.0±18.34ms        ? ?/sec    1.01    984.2±6.28ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1208.7±15.43ms        ? ?/sec    1.03  1243.0±19.57ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    432.2±4.68ms        ? ?/sec    1.03    445.3±2.79ms        ? ?/sec
remapping/remapping                                                 1.00     32.2±0.16ms        ? ?/sec    1.03     33.2±0.23ms        ? ?/sec
remapping/render-chunk-remapping                                    1.01     83.6±0.36ms        ? ?/sec    1.00     82.5±0.91ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     82.0±1.31ms        ? ?/sec    1.01     82.6±1.46ms        ? ?/sec
scan/scan@threejs                                                   1.00     25.4±0.68ms        ? ?/sec    1.00     25.5±0.88ms        ? ?/sec
scan/scan@threejs10x                                                1.00    254.6±1.77ms        ? ?/sec    1.01    256.7±1.62ms        ? ?/sec

This was referenced Sep 5, 2024
Merged
Merged
Merged
@hyf0 hyf0 self-assigned this Sep 6, 2024
@hyf0 hyf0 added this pull request to the merge queue Sep 6, 2024
Merged via the queue into main with commit 1e9c2d9 Sep 6, 2024
@hyf0 hyf0 deleted the 09-05-feat_rust_advance-chunks_support_min_size_option branch September 6, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@hyf0 hyf0

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hyf0