Skip to content

fix(rolldown): side effect detector mark +1 -1 as number literal#2162

Merged
IWANABETHATGUY merged 4 commits intomainfrom
fix/number-literal-as-computed-key
Sep 5, 2024
Merged

fix(rolldown): side effect detector mark +1 -1 as number literal#2162
IWANABETHATGUY merged 4 commits intomainfrom
fix/number-literal-as-computed-key

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Sep 4, 2024

Description

@netlify
Copy link

netlify bot commented Sep 4, 2024 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit ae94c36
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66d9550efd4aec00087866ea

@IWANABETHATGUY IWANABETHATGUY changed the title Fix/number literal as computed key fix: should considered +1 -1 as number literal Sep 4, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024 •
edited
Loading

Benchmarks Rust

  • target: main(071efd8)
  • pr: fix/number-literal-as-computed-key(ae94c36)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.02     56.2±0.96ms        ? ?/sec    1.00     55.4±1.32ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.01     80.6±2.50ms        ? ?/sec    1.00     79.4±2.16ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     95.9±1.46ms        ? ?/sec    1.02     98.0±2.53ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     63.6±0.81ms        ? ?/sec    1.01     64.4±1.10ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    101.5±1.17ms        ? ?/sec    1.01    102.0±1.08ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.01    195.8±8.14ms        ? ?/sec    1.00    194.7±5.48ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.01    239.9±8.10ms        ? ?/sec    1.00    238.2±8.62ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.01    119.4±1.14ms        ? ?/sec    1.00    117.7±1.74ms        ? ?/sec
bundle/bundle@threejs                                               1.05     34.6±1.24ms        ? ?/sec    1.00     33.0±0.48ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.03     83.7±1.39ms        ? ?/sec    1.00     80.9±1.41ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.03    103.6±3.39ms        ? ?/sec    1.00    100.7±3.30ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.04     44.4±0.80ms        ? ?/sec    1.00     42.6±0.89ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    359.2±3.53ms        ? ?/sec    1.01    362.7±3.76ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   949.8±14.17ms        ? ?/sec    1.01   961.8±15.39ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1203.3±26.55ms        ? ?/sec    1.00  1207.3±12.78ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.01    429.2±3.24ms        ? ?/sec    1.00    425.9±3.08ms        ? ?/sec
remapping/remapping                                                 1.00     32.6±0.30ms        ? ?/sec    1.02     33.2±0.48ms        ? ?/sec
remapping/render-chunk-remapping                                    1.02     83.1±0.44ms        ? ?/sec    1.00     81.4±0.40ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     82.7±0.76ms        ? ?/sec    1.00     82.5±0.71ms        ? ?/sec
scan/scan@threejs                                                   1.01     26.3±1.07ms        ? ?/sec    1.00     26.0±1.13ms        ? ?/sec
scan/scan@threejs10x                                                1.00    259.8±2.57ms        ? ?/sec    1.00    258.5±2.62ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review September 4, 2024 16:29
@Boshen Boshen changed the title fix: should considered +1 -1 as number literal fix(rolldown): side effect detector mark +1 -1 as number literal Sep 5, 2024
Boshen
Boshen reviewed Sep 5, 2024
View reviewed changes
Boshen
Boshen reviewed Sep 5, 2024
View reviewed changes
Boshen
Boshen reviewed Sep 5, 2024
View reviewed changes
@IWANABETHATGUY IWANABETHATGUY force-pushed the fix/number-literal-as-computed-key branch from 57c170b to ae94c36 Compare September 5, 2024 06:51
@IWANABETHATGUY IWANABETHATGUY self-assigned this Sep 5, 2024
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit 40ae24d Sep 5, 2024
@IWANABETHATGUY IWANABETHATGUY deleted the fix/number-literal-as-computed-key branch September 5, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Boshen Boshen Boshen left review comments

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@IWANABETHATGUY IWANABETHATGUY

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IWANABETHATGUY @Boshen