fix: mark knownGlobals global ident and global member access as side effects free#2154
Merged
IWANABETHATGUY merged 3 commits intomainfrom Sep 4, 2024
Merged
fix: mark knownGlobals global ident and global member access as side effects free#2154IWANABETHATGUY merged 3 commits intomainfrom
IWANABETHATGUY merged 3 commits intomainfrom
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
IWANABETHATGUY
commented
Sep 4, 2024
| const Symbol_dispose_remove = Symbol.dispose; | ||
| const Symbol_asyncDispose_remove = Symbol.asyncDispose; | ||
| console.log(null_keep, undef_keep); | ||
|
|
Member
Author
There was a problem hiding this comment.
// entry.js
using null_keep = null;
await using await_null_keep = null;
using throw_keep = {};
using dispose_keep = { [Symbol.dispose]() {
console.log("side effect");
} };
await using await_asyncDispose_keep = { [Symbol.asyncDispose]() {
console.log("side effect");
} };
using undef_keep = void 0;
await using await_undef_keep = void 0;
console.log(
null_keep,
undef_keep
);
Still not same as esbuild, but not relevant to this pr, these two stmt is removed either in esbuild snapshot
Contributor
Benchmarks Rust |
hyf0
approved these changes
Sep 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ref:
https://github.com/evanw/esbuild/blob/9c13ae1f06dfa909eb4a53882e3b7e4216a503fe/internal/config/globals.go#L30-L850
https://github.com/evanw/esbuild/blob/9c13ae1f06dfa909eb4a53882e3b7e4216a503fe/internal/config/globals.go#L940-L961