Skip to content

feat(rust/advance-chunks): rework with new API deisgn#2146

Merged
hyf0 merged 1 commit intomainfrom
09-04-feat_rust_advance-chunks_rewoker_with_new_api_deisgn
Sep 4, 2024
Merged

feat(rust/advance-chunks): rework with new API deisgn#2146
hyf0 merged 1 commit intomainfrom
09-04-feat_rust_advance-chunks_rewoker_with_new_api_deisgn

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Sep 3, 2024 •
edited
Loading

Description

refer: #2118

@hyf0 Graphite App
Copy link
Member Author

hyf0 commented Sep 3, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

@netlify
Copy link

netlify bot commented Sep 3, 2024 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 0b98c7b
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66d809360f95e60008b203cb

@hyf0 hyf0 marked this pull request as ready for review September 3, 2024 22:13
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024 •
edited
Loading

Benchmarks Rust

  • target: main(d24c337)
  • pr: 09-04-feat_rust_advance-chunks_rewoker_with_new_api_deisgn(0b98c7b)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     52.6±0.93ms        ? ?/sec    1.10     57.7±0.82ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     78.0±1.36ms        ? ?/sec    1.06     82.4±1.29ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     96.2±2.03ms        ? ?/sec    1.03     98.6±2.61ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     62.8±2.68ms        ? ?/sec    1.03     64.8±1.32ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00     98.9±0.90ms        ? ?/sec    1.04    102.6±1.06ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    176.6±2.63ms        ? ?/sec    1.12    198.6±5.06ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    225.2±6.11ms        ? ?/sec    1.08    242.2±4.14ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    116.1±1.78ms        ? ?/sec    1.02    118.9±1.23ms        ? ?/sec
bundle/bundle@threejs                                               1.00     32.3±0.48ms        ? ?/sec    1.06     34.2±0.33ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     79.5±2.46ms        ? ?/sec    1.03     81.7±1.22ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00     98.0±1.12ms        ? ?/sec    1.04    102.0±1.93ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     41.5±0.80ms        ? ?/sec    1.03     42.6±0.18ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    349.9±3.80ms        ? ?/sec    1.03    361.1±2.45ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   940.3±11.50ms        ? ?/sec    1.03    964.0±7.16ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   1192.6±8.26ms        ? ?/sec    1.03   1227.8±8.00ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    414.2±3.57ms        ? ?/sec    1.04    428.7±3.29ms        ? ?/sec
remapping/remapping                                                 1.00     32.9±0.20ms        ? ?/sec    1.00     33.0±0.16ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     82.1±0.54ms        ? ?/sec    1.00     82.2±0.30ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     84.8±1.97ms        ? ?/sec    1.00     84.5±1.21ms        ? ?/sec
scan/scan@threejs                                                   1.00     26.1±0.70ms        ? ?/sec    1.01     26.3±0.78ms        ? ?/sec
scan/scan@threejs10x                                                1.00    258.3±3.92ms        ? ?/sec    1.00    259.5±2.36ms        ? ?/sec

underfin
underfin reviewed Sep 4, 2024
View reviewed changes
crates/rolldown/src/stages/generate_stage/code_splitting.rs
let mut name_to_module_group: FxHashMap<ArcStr, ModuleGroup> = FxHashMap::default();

for normal_module in self.link_output.module_table.modules.iter().filter_map(Module::as_ecma) {
if !normal_module.is_included {
Copy link
Contributor

@underfin underfin Sep 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here lost

if module_to_assigned[normal_module.idx] {
      continue;
      }

Copy link
Member Author

@hyf0 hyf0 Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need. A module won't show twice here

@IWANABETHATGUY
Copy link
Member

IWANABETHATGUY commented Sep 4, 2024

Do you mean rework in title?

@hyf0 hyf0 changed the title feat(rust/advance-chunks): rewoker with new API deisgn feat(rust/advance-chunks): rework with new API deisgn Sep 4, 2024
@hyf0
Copy link
Member Author

hyf0 commented Sep 4, 2024

Do you mean rework in title?

Yeah.

@hyf0 hyf0 force-pushed the 09-04-feat_rust_advance-chunks_rewoker_with_new_api_deisgn branch from 9aa9363 to 0b98c7b Compare September 4, 2024 07:16
@hyf0 hyf0 mentioned this pull request Sep 4, 2024
Merged
@hyf0 hyf0 self-assigned this Sep 4, 2024
@hyf0 hyf0 added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit 6339062 Sep 4, 2024
@hyf0 hyf0 deleted the 09-04-feat_rust_advance-chunks_rewoker_with_new_api_deisgn branch September 4, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

+1 more reviewer

@underfin underfin underfin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@hyf0 hyf0

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hyf0 @IWANABETHATGUY @underfin