Skip to content

fix: entry chunk should be at first#2089

Merged
hyf0 merged 14 commits intomainfrom
fix-entry-chunk-orde
Aug 30, 2024
Merged

fix: entry chunk should be at first#2089
hyf0 merged 14 commits intomainfrom
fix-entry-chunk-orde

Conversation

@underfin
Copy link
Copy Markdown
Contributor

@underfin underfin commented Aug 29, 2024

Description

The rollup entry chunks should be at first, we need to make sure the behavior.

@netlify
Copy link
Copy Markdown

netlify bot commented Aug 29, 2024 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 7247b1a
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66d1aeff2b653f00082b4aac

@underfin underfin marked this pull request as draft August 29, 2024 09:44
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 29, 2024 •
edited
Loading

Benchmarks Rust

group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     52.6±1.58ms        ? ?/sec    1.09     57.2±0.83ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     79.0±2.10ms        ? ?/sec    1.01     79.9±1.61ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     95.3±1.31ms        ? ?/sec    1.03     98.4±1.93ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     61.3±1.39ms        ? ?/sec    1.07     65.8±1.93ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    103.4±1.58ms        ? ?/sec    1.01    104.7±1.24ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    180.7±3.88ms        ? ?/sec    1.17    211.6±2.80ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    238.0±6.87ms        ? ?/sec    1.07    254.5±6.35ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    118.4±1.08ms        ? ?/sec    1.02    120.7±1.16ms        ? ?/sec
bundle/bundle@threejs                                               1.08     38.9±0.92ms        ? ?/sec    1.00     36.0±0.49ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.01     86.2±2.45ms        ? ?/sec    1.00     85.0±5.29ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.09    108.8±4.65ms        ? ?/sec    1.00     99.6±1.78ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.02     47.2±0.91ms        ? ?/sec    1.00     46.1±0.66ms        ? ?/sec
bundle/bundle@threejs10x                                            1.02    402.0±5.91ms        ? ?/sec    1.00    395.0±4.20ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.01   1020.0±9.37ms        ? ?/sec    1.00  1011.8±12.16ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1272.7±15.03ms        ? ?/sec    1.00  1268.9±16.63ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.01    475.6±4.26ms        ? ?/sec    1.00    470.8±4.45ms        ? ?/sec
remapping/remapping                                                 1.02     33.2±0.14ms        ? ?/sec    1.00     32.7±0.10ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     83.7±0.68ms        ? ?/sec    1.00     83.6±0.49ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     82.9±1.07ms        ? ?/sec    1.01     83.8±1.70ms        ? ?/sec
scan/scan@threejs                                                   1.02     28.7±0.21ms        ? ?/sec    1.00     28.3±0.31ms        ? ?/sec
scan/scan@threejs10x                                                1.01    288.7±1.93ms        ? ?/sec    1.00    287.3±2.17ms        ? ?/sec

@underfin underfin marked this pull request as ready for review August 29, 2024 10:00
@underfin underfin added this pull request to the merge queue Aug 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2024
@underfin underfin force-pushed the fix-entry-chunk-orde branch from 42e82bd to fa1cab1 Compare August 29, 2024 10:23
@underfin underfin enabled auto-merge August 29, 2024 10:23
@underfin underfin disabled auto-merge August 30, 2024 04:11
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Aug 30, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #2089 will not alter performance

Comparing fix-entry-chunk-orde (7247b1a) with main (33fca46)

Summary

✅ 21 untouched benchmarks

underfin
underfin commented Aug 30, 2024
View reviewed changes
crates/rolldown/src/stages/generate_stage/code_splitting.rs
ChunkKind::EntryPoint { is_user_defined: b_is_user_defined, .. },
) => {
if *a_is_user_defined && *b_is_user_defined {
// Using user specific order of entry
Copy link
Copy Markdown
Contributor Author

@underfin underfin Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here fixed user specific order of entry

Copy link
Copy Markdown
Member

@hyf0 hyf0 Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make sure the entry asset order is the same as the user's input option?

@underfin underfin requested a review from hyf0 August 30, 2024 11:38
@hyf0
Copy link
Copy Markdown
Member

hyf0 commented Aug 30, 2024

Since there are no failing on tests, let's merged it first.

@hyf0 hyf0 added this pull request to the merge queue Aug 30, 2024
Merged via the queue into main with commit 8b7734e Aug 30, 2024
@hyf0 hyf0 deleted the fix-entry-chunk-orde branch August 30, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@underfin @hyf0