Skip to content

fix: external module side effects should respect hook returned side e…#2068

Merged
underfin merged 1 commit intomainfrom
fix-respect-moduleSideEffects-external-hook
Aug 26, 2024
Merged

fix: external module side effects should respect hook returned side e…#2068
underfin merged 1 commit intomainfrom
fix-respect-moduleSideEffects-external-hook

Conversation

@underfin
Copy link
Copy Markdown
Contributor

@underfin underfin commented Aug 26, 2024

…ffects

Description

@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 26, 2024

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 81be909
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66cc4e0308104d0008a378dd

@underfin underfin enabled auto-merge August 26, 2024 09:49
@underfin underfin added this pull request to the merge queue Aug 26, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 26, 2024

Benchmarks Rust

  • target: main(94cb434)
  • pr: fix-respect-moduleSideEffects-external-hook(81be909)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     51.9±0.88ms        ? ?/sec    1.00     52.0±1.09ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.04     77.8±1.36ms        ? ?/sec    1.00     74.9±1.10ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.03     95.2±1.58ms        ? ?/sec    1.00     92.4±1.47ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.01     61.2±2.60ms        ? ?/sec    1.00     60.4±0.95ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    100.9±1.13ms        ? ?/sec    1.01    101.4±1.39ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.01    185.1±3.03ms        ? ?/sec    1.00    183.0±4.62ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    231.2±4.33ms        ? ?/sec    1.00    230.2±4.11ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    117.0±1.12ms        ? ?/sec    1.01    118.1±2.53ms        ? ?/sec
bundle/bundle@threejs                                               1.00     35.9±0.20ms        ? ?/sec    1.00     36.1±0.98ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     80.4±1.41ms        ? ?/sec    1.01     81.2±1.37ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.01    101.4±2.12ms        ? ?/sec    1.00    100.5±1.88ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.01     45.5±0.87ms        ? ?/sec    1.00     45.2±0.51ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    389.8±3.72ms        ? ?/sec    1.00    388.9±2.55ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   994.3±12.56ms        ? ?/sec    1.00   994.3±10.11ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.01   1261.4±9.28ms        ? ?/sec    1.00  1248.1±11.49ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.01    463.0±5.09ms        ? ?/sec    1.00    456.7±2.06ms        ? ?/sec
remapping/remapping                                                 1.00     32.1±0.34ms        ? ?/sec    1.02     32.7±0.39ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     81.9±0.58ms        ? ?/sec    1.01     82.9±0.82ms        ? ?/sec
scan/scan@rome-ts                                                   1.01     81.4±0.58ms        ? ?/sec    1.00     80.3±1.03ms        ? ?/sec
scan/scan@threejs                                                   1.01     28.7±0.90ms        ? ?/sec    1.00     28.4±0.69ms        ? ?/sec
scan/scan@threejs10x                                                1.01    288.9±1.84ms        ? ?/sec    1.00    287.2±3.61ms        ? ?/sec

Merged via the queue into main with commit 0f9391b Aug 26, 2024
@underfin underfin deleted the fix-respect-moduleSideEffects-external-hook branch August 26, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@underfin @IWANABETHATGUY