Skip to content

feat: hook filter#2047

Merged
IWANABETHATGUY merged 15 commits intomainfrom
feat/hook-filter
Aug 31, 2024
Merged

feat: hook filter#2047
IWANABETHATGUY merged 15 commits intomainfrom
feat/hook-filter

Conversation

@IWANABETHATGUY
Copy link
Copy Markdown
Member

@IWANABETHATGUY IWANABETHATGUY commented Aug 23, 2024

Description

@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 23, 2024 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 8eb5dc0
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66d2cc3868c260000850afc0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 23, 2024 •
edited
Loading

Benchmarks Rust

group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     52.5±0.55ms        ? ?/sec    1.00     52.3±0.72ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.01     77.1±1.55ms        ? ?/sec    1.00     76.5±0.78ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     93.6±0.90ms        ? ?/sec    1.01     94.2±1.38ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.01     60.7±0.66ms        ? ?/sec    1.00     60.4±0.72ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    101.2±0.90ms        ? ?/sec    1.00    100.9±0.84ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    181.2±2.35ms        ? ?/sec    1.00    180.9±2.23ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.02    227.6±2.20ms        ? ?/sec    1.00    224.1±2.12ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    116.8±1.31ms        ? ?/sec    1.00    116.7±3.58ms        ? ?/sec
bundle/bundle@threejs                                               1.00     36.1±0.91ms        ? ?/sec    1.01     36.4±0.92ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     80.8±2.49ms        ? ?/sec    1.02     82.1±0.71ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00     98.1±2.52ms        ? ?/sec    1.02    100.4±1.50ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.01     45.6±0.25ms        ? ?/sec    1.00     45.0±0.33ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    383.3±1.92ms        ? ?/sec    1.01    387.9±6.45ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00    970.9±5.19ms        ? ?/sec    1.00    969.7±7.51ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   1224.5±8.53ms        ? ?/sec    1.00  1228.7±10.75ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    453.5±6.28ms        ? ?/sec    1.00    451.6±2.87ms        ? ?/sec
remapping/remapping                                                 1.00     33.1±0.13ms        ? ?/sec    1.00     33.2±0.14ms        ? ?/sec
remapping/render-chunk-remapping                                    1.01     83.7±0.39ms        ? ?/sec    1.00     82.9±0.78ms        ? ?/sec
scan/scan@rome-ts                                                   1.01     81.6±0.67ms        ? ?/sec    1.00     80.4±0.62ms        ? ?/sec
scan/scan@threejs                                                   1.00     28.5±0.13ms        ? ?/sec    1.00     28.5±0.81ms        ? ?/sec
scan/scan@threejs10x                                                1.01    288.3±2.46ms        ? ?/sec    1.00    285.9±2.04ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY changed the title Feat/hook filter feat: hook filter Aug 24, 2024
hyf0
hyf0 reviewed Aug 26, 2024
View reviewed changes
Comment thread crates/rolldown_plugin/src/plugin.rs Outdated
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review August 31, 2024 07:55
@IWANABETHATGUY
Copy link
Copy Markdown
Member Author

IWANABETHATGUY commented Aug 31, 2024

merged since it needs to test in rolldown-vite, all tests are passed, TODO: needs support filter with compose-js-plugin

@IWANABETHATGUY IWANABETHATGUY requested a review from hyf0 August 31, 2024 07:57
@IWANABETHATGUY IWANABETHATGUY self-assigned this Aug 31, 2024
@IWANABETHATGUY IWANABETHATGUY removed their assignment Aug 31, 2024
@IWANABETHATGUY IWANABETHATGUY self-assigned this Aug 31, 2024
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Aug 31, 2024
Merged via the queue into main with commit 6039415 Aug 31, 2024
@IWANABETHATGUY IWANABETHATGUY deleted the feat/hook-filter branch August 31, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@hyf0 hyf0 Awaiting requested review from hyf0

Assignees

@IWANABETHATGUY IWANABETHATGUY

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IWANABETHATGUY @hyf0