✅ Deploy Preview for rolldown-rs canceled.

And for for*stmt, esbuild considering they all have side effects. https://github.com/evanw/esbuild/blob/9c13ae1f06dfa909eb4a53882e3b7e4216a503fe/internal/js_ast/js_ast_helpers.go#L2289-L2293

And for for*stmt, esbuild considering they all have side effects. evanw/esbuild@9c13ae1/internal/js_ast/js_ast_helpers.go#L2289-L2293

This PR has the same logic as Rollup's: for-in, for-of, for. Which one should we follow?

for, TaggedTemplateExpression:
evanw/esbuild@9c13ae1/internal/js_ast/js_ast_helpers.go#L2578-L2590

Yes, esbuild uses e.TagOrNil.Data == nil to exclude tagged template literal.

And for for*stmt, esbuild considering they all have side effects. evanw/esbuild@9c13ae1/internal/js_ast/js_ast_helpers.go#L2289-L2293

This PR has the same logic as Rollup's: for-in, for-of, for. Which one should we follow?

for, TaggedTemplateExpression:
evanw/esbuild@9c13ae1/internal/js_ast/js_ast_helpers.go#L2578-L2590

Yes, esbuild uses e.TagOrNil.Data == nil to exclude tagged template literal.

follow Esbuild.
https://rollupjs.org/repl/?version=4.20.0&shareable=JTdCJTIyZXhhbXBsZSUyMiUzQW51bGwlMkMlMjJtb2R1bGVzJTIyJTNBJTVCJTdCJTIyY29kZSUyMiUzQSUyMmltcG9ydCUyMCU3QnNxdWFyZSU3RCUyMGZyb20lMjAnLiUyRm1hdGhzLmpzJyU1Q24lMkJzcXVhcmUlMjIlMkMlMjJpc0VudHJ5JTIyJTNBdHJ1ZSUyQyUyMm5hbWUlMjIlM0ElMjJtYWluLmpzJTIyJTdEJTJDJTdCJTIyY29kZSUyMiUzQSUyMk9iamVjdC5wcm90b3R5cGUudmFsdWVPZiUyMCUzRCUyMGZ1bmN0aW9uKHYpJTIwJTdCJTVDbiUyMCUyMGNvbnNvbGUubG9nKCd0ZXN0JyklNUNuJTIwJTIwcmV0dXJuJTIwMCUzQiU1Q24lN0QlNUNuJTVDbmxldCUyMGElMjAlM0QlMjAlN0IlN0QlM0IlNUNuJTJCJTdCJTdEJTVDbiU1Q25leHBvcnQlMjBjb25zdCUyMHNxdWFyZSUyMCUzRCUyMCU3QiU3RCU1Q24lMjIlMkMlMjJpc0VudHJ5JTIyJTNBZmFsc2UlMkMlMjJuYW1lJTIyJTNBJTIybWF0aHMuanMlMjIlN0QlNUQlMkMlMjJvcHRpb25zJTIyJTNBJTdCJTIyb3V0cHV0JTIyJTNBJTdCJTIyZm9ybWF0JTIyJTNBJTIyZXMlMjIlN0QlMkMlMjJ0cmVlc2hha2UlMjIlM0ElMjJzYWZlc3QlMjIlN0QlN0Q=
It't not too hard to generate unsafe behavior in Rollup safest treeshaking.

And for for*stmt, esbuild considering they all have side effects. evanw/esbuild@9c13ae1/internal/js_ast/js_ast_helpers.go#L2289-L2293

This PR has the same logic as Rollup's: for-in, for-of, for. Which one should we follow?

for, TaggedTemplateExpression:
evanw/esbuild@9c13ae1/internal/js_ast/js_ast_helpers.go#L2578-L2590

Yes, esbuild uses e.TagOrNil.Data == nil to exclude tagged template literal.

follow Esbuild. https://rollupjs.org/repl/?version=4.20.0&shareable=JTdCJTIyZXhhbXBsZSUyMiUzQW51bGwlMkMlMjJtb2R1bGVzJTIyJTNBJTVCJTdCJTIyY29kZSUyMiUzQSUyMmltcG9ydCUyMCU3QnNxdWFyZSU3RCUyMGZyb20lMjAnLiUyRm1hdGhzLmpzJyU1Q24lMkJzcXVhcmUlMjIlMkMlMjJpc0VudHJ5JTIyJTNBdHJ1ZSUyQyUyMm5hbWUlMjIlM0ElMjJtYWluLmpzJTIyJTdEJTJDJTdCJTIyY29kZSUyMiUzQSUyMk9iamVjdC5wcm90b3R5cGUudmFsdWVPZiUyMCUzRCUyMGZ1bmN0aW9uKHYpJTIwJTdCJTVDbiUyMCUyMGNvbnNvbGUubG9nKCd0ZXN0JyklNUNuJTIwJTIwcmV0dXJuJTIwMCUzQiU1Q24lN0QlNUNuJTVDbmxldCUyMGElMjAlM0QlMjAlN0IlN0QlM0IlNUNuJTJCJTdCJTdEJTVDbiU1Q25leHBvcnQlMjBjb25zdCUyMHNxdWFyZSUyMCUzRCUyMCU3QiU3RCU1Q24lMjIlMkMlMjJpc0VudHJ5JTIyJTNBZmFsc2UlMkMlMjJuYW1lJTIyJTNBJTIybWF0aHMuanMlMjIlN0QlNUQlMkMlMjJvcHRpb25zJTIyJTNBJTdCJTIyb3V0cHV0JTIyJTNBJTdCJTIyZm9ybWF0JTIyJTNBJTIyZXMlMjIlN0QlMkMlMjJ0cmVlc2hha2UlMjIlM0ElMjJzYWZlc3QlMjIlN0QlN0Q= It't not too hard to generate unsafe behavior in Rollup safest treeshaking.

I did not mean esbuild could avoid all unsafe scenarios, but it is much better. Also our goal is to pass 100% esbuild tests in the future.