feat: assignment expr side effect detector#2004
Merged
IWANABETHATGUY merged 7 commits intorolldown:mainfrom Aug 17, 2024
Merged
feat: assignment expr side effect detector#2004IWANABETHATGUY merged 7 commits intorolldown:mainfrom
IWANABETHATGUY merged 7 commits intorolldown:mainfrom
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
Contributor
|
There is one case, but I don't think it often occurs in actual coding. with(obj) {
[] = x;
} |
IWANABETHATGUY
approved these changes
Aug 17, 2024
Co-authored-by: IWANABETHATGUY <974153916@qq.com>
auto-merge was automatically disabled
August 17, 2024 04:37
Head branch was pushed to by a user without write access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the logic for
AssignmentExpressioninSideEffectDetector. Tests included.[] = a,{} = aare considered side-effect-less whenais a local variable. However, it seems that neither Rollup nor Esbuild considered this case.{ defineProperty: x } = Objectbe specially treated? This will introduce lots of complexity, but the usage seems too rare.