Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
Boshen
commented
Aug 10, 2024
Boshen
commented
Aug 10, 2024
Contributor
Benchmarks Rust |
CodSpeed Performance ReportMerging #1933 will degrade performances by 17.69%Comparing Summary
Benchmarks breakdown
|
Member
|
Any idea about why performance get down so much even we don't use inject? ---edited Besides adding skipping logic, even we do a full-ast traverse with empty options, it shouldn't slow that much. This PR adds a almost full-ast traverse pass, but have little affection. |
inject imports
hyf0
reviewed
Aug 10, 2024
| assert.strictEqual(P, 'promise-shim') | ||
| assert.strictEqual($, 'jquery') | ||
| assert.strictEqual(fs.default, 'node-fs') | ||
| // FIXME: oxc injects invalid statements `import { default as 'Object.assign' from 'object-assign-shim'` }`, so it fails. |
Member
There was a problem hiding this comment.
@Boshen cc
There is a bug here.
I take a rough look
oxc transform to the following code
import { default as 'Object.assign'} from 'object-assign-shim'`This is invalid js code.
while it should be
import { default as Object_assign} from 'object-assign-shim'`or
import Object_assign from 'object-assign-shim'`
hyf0
approved these changes
Aug 10, 2024
Member
Author
This is because semantic is now run for each file in this file, where previously its only run for ts or jsx files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the missing pieces for inject plugin.