Skip to content

fix: circular ref in rolldown package bundle#1849

Merged
hyf0 merged 2 commits intomainfrom
fix/cycle-ref-in-js-side
Aug 2, 2024
Merged

fix: circular ref in rolldown package bundle#1849
hyf0 merged 2 commits intomainfrom
fix/cycle-ref-in-js-side

Conversation

@IWANABETHATGUY
Copy link
Copy Markdown
Member

Description

[CIRCULAR_DEPENDENCY] Warning: Circular dependency: src/utils/index.ts -> src/utils/create-bundler.ts -> src/options/bindingify-input-options.ts -> src/plugin/bindingify-plugin.ts -> src/pl
ugin/plugin-context-data.ts -> src/utils/index.ts.

@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 2, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 28163d4
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66ad05c12ebedb00080ddfc7

@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 2, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 6f2e0d5
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66ad1432b6ee570008d76eec

@IWANABETHATGUY IWANABETHATGUY changed the title fix: cycle ref in rolldown package bundle fix: circular ref in rolldown package bundle Aug 2, 2024
@hyf0
Copy link
Copy Markdown
Member

hyf0 commented Aug 2, 2024

export * from './async-flatten'
export * from './transform-to-rollup-output'
export * from './normalize-plugin-option'
export * from './ensure-array'
export * from './create-bundler'
export * from './transform-sourcemap'
export * from './transform-module-info'
export * from './code-frame'
export * from './misc'

Main evils are here. Should just delete index.ts and make everything work.

@IWANABETHATGUY
Copy link
Copy Markdown
Member Author

export * from './async-flatten'
export * from './transform-to-rollup-output'
export * from './normalize-plugin-option'
export * from './ensure-array'
export * from './create-bundler'
export * from './transform-sourcemap'
export * from './transform-module-info'
export * from './code-frame'
export * from './misc'

Main evils are here. Should just delete index.ts and make everything work.

ok

@IWANABETHATGUY IWANABETHATGUY force-pushed the fix/cycle-ref-in-js-side branch from b85ec35 to 420989d Compare August 2, 2024 16:35
@IWANABETHATGUY IWANABETHATGUY force-pushed the fix/cycle-ref-in-js-side branch from 420989d to 6f2e0d5 Compare August 2, 2024 17:15
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review August 2, 2024 17:15
@hyf0 hyf0 added this pull request to the merge queue Aug 2, 2024
Merged via the queue into main with commit 3c3cb83 Aug 2, 2024
@hyf0 hyf0 deleted the fix/cycle-ref-in-js-side branch August 2, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants