Skip to content

feat: module preload config skip#1845

Merged
IWANABETHATGUY merged 6 commits intomainfrom
chore/module-preload-skip
Aug 5, 2024
Merged

feat: module preload config skip#1845
IWANABETHATGUY merged 6 commits intomainfrom
chore/module-preload-skip

Conversation

@IWANABETHATGUY
Copy link
Copy Markdown
Member

@IWANABETHATGUY IWANABETHATGUY commented Aug 2, 2024

Description

@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 2, 2024 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit a49d12b
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66b03808cf611a0008e90e62

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 2, 2024 •
edited
Loading

Benchmarks Rust

group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     46.3±0.78ms        ? ?/sec    1.00     46.2±0.83ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     62.3±0.61ms        ? ?/sec    1.01     62.7±0.57ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     80.7±0.70ms        ? ?/sec    1.00     80.5±0.64ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     54.9±0.73ms        ? ?/sec    1.01     55.2±0.74ms        ? ?/sec
bundle/bundle@rome-ts                                               1.01     88.6±0.91ms        ? ?/sec    1.00     88.1±1.11ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.01    140.8±1.53ms        ? ?/sec    1.00    139.5±1.66ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    183.5±1.77ms        ? ?/sec    1.00    183.0±1.69ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.01    107.4±2.10ms        ? ?/sec    1.00    106.3±1.20ms        ? ?/sec
bundle/bundle@threejs                                               1.00     26.2±0.50ms        ? ?/sec    1.00     26.1±0.23ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     59.0±0.79ms        ? ?/sec    1.00     58.8±0.55ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00     77.8±1.57ms        ? ?/sec    1.00     77.8±0.83ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.01     37.9±0.41ms        ? ?/sec    1.00     37.4±0.38ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    290.4±2.13ms        ? ?/sec    1.00    291.2±2.25ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.01    665.2±5.06ms        ? ?/sec    1.00    661.5±6.45ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.01    892.3±7.26ms        ? ?/sec    1.00    886.2±4.92ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.02    393.7±6.73ms        ? ?/sec    1.00    386.2±8.41ms        ? ?/sec
remapping/remapping                                                 1.03     35.5±1.44ms        ? ?/sec    1.00     34.5±0.62ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     83.3±1.20ms        ? ?/sec    1.00     83.1±0.42ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     70.3±0.92ms        ? ?/sec    1.01     70.8±0.61ms        ? ?/sec
scan/scan@threejs                                                   1.01     19.4±0.46ms        ? ?/sec    1.00     19.3±0.10ms        ? ?/sec
scan/scan@threejs10x                                                1.00    197.9±1.95ms        ? ?/sec    1.01    199.8±1.48ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY force-pushed the chore/module-preload-skip branch from 425e8ca to da62ffb Compare August 4, 2024 10:07
@IWANABETHATGUY
Copy link
Copy Markdown
Member Author

IWANABETHATGUY commented Aug 4, 2024

After discussing with @underfin we decide to keep align with the upstream vite plugin 1:1 as much as possible , this could reduce a lot of work when preparing migration.

@IWANABETHATGUY IWANABETHATGUY force-pushed the chore/module-preload-skip branch from 76e573d to 7e62d5c Compare August 4, 2024 12:07
@IWANABETHATGUY IWANABETHATGUY requested a review from underfin August 4, 2024 12:21
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review August 4, 2024 14:32
@IWANABETHATGUY IWANABETHATGUY force-pushed the chore/module-preload-skip branch from 7e62d5c to a49d12b Compare August 5, 2024 02:25
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Aug 5, 2024
Merged via the queue into main with commit f55cfda Aug 5, 2024
@IWANABETHATGUY IWANABETHATGUY deleted the chore/module-preload-skip branch August 5, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@underfin underfin underfin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IWANABETHATGUY @underfin