Skip to content

fix: should call write_bundle after write bundle to disk#1844

Merged
underfin merged 1 commit intomainfrom
make-sure-bundle-already-write-to-disk-bfore-writeBundle
Aug 2, 2024
Merged

fix: should call write_bundle after write bundle to disk#1844
underfin merged 1 commit intomainfrom
make-sure-bundle-already-write-to-disk-bfore-writeBundle

Conversation

@underfin
Copy link
Contributor

@underfin underfin commented Aug 2, 2024 •
edited
Loading

@netlify
Copy link

netlify bot commented Aug 2, 2024

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 8356912
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66acb0fac4c04a0008804786

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024

Benchmarks Rust

  • target: main(145f105)
  • pr: make-sure-bundle-already-write-to-disk-bfore-writeBundle(8356912)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     47.4±0.83ms        ? ?/sec    1.01     47.9±0.96ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     63.3±0.80ms        ? ?/sec    1.03     65.3±0.75ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     80.9±0.91ms        ? ?/sec    1.02     82.3±1.32ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     55.9±0.83ms        ? ?/sec    1.01     56.2±0.78ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00     89.8±0.97ms        ? ?/sec    1.00     89.5±1.20ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.02    146.1±2.82ms        ? ?/sec    1.00    143.2±2.49ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.02    189.2±2.01ms        ? ?/sec    1.00    186.0±2.96ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.01    108.8±2.45ms        ? ?/sec    1.00    107.4±0.95ms        ? ?/sec
bundle/bundle@threejs                                               1.00     26.7±0.31ms        ? ?/sec    1.01     26.8±1.17ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     57.8±1.33ms        ? ?/sec    1.03     59.5±0.74ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00     78.2±1.82ms        ? ?/sec    1.00     77.9±0.95ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.01     38.3±0.50ms        ? ?/sec    1.00     37.8±0.57ms        ? ?/sec
bundle/bundle@threejs10x                                            1.01    297.8±2.58ms        ? ?/sec    1.00    296.1±3.00ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.01    667.4±5.30ms        ? ?/sec    1.00    663.8±6.42ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.01    889.0±4.41ms        ? ?/sec    1.00    883.1±6.59ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    394.2±8.37ms        ? ?/sec    1.01   396.4±10.04ms        ? ?/sec
remapping/remapping                                                 1.01     35.3±0.22ms        ? ?/sec    1.00     35.1±0.09ms        ? ?/sec
remapping/render-chunk-remapping                                    1.01     83.4±0.49ms        ? ?/sec    1.00     82.6±1.17ms        ? ?/sec
scan/scan@rome-ts                                                   1.01     71.7±0.52ms        ? ?/sec    1.00     71.2±0.77ms        ? ?/sec
scan/scan@threejs                                                   1.02     19.8±0.86ms        ? ?/sec    1.00     19.5±0.54ms        ? ?/sec
scan/scan@threejs10x                                                1.03    204.1±2.64ms        ? ?/sec    1.00    198.4±1.17ms        ? ?/sec

@underfin underfin added this pull request to the merge queue Aug 2, 2024
Merged via the queue into main with commit 475f765 Aug 2, 2024
@underfin underfin deleted the make-sure-bundle-already-write-to-disk-bfore-writeBundle branch August 2, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@underfin @IWANABETHATGUY