Skip to content

fix: using sanitize_file_name to generate valid file name#1833

Merged
underfin merged 3 commits intomainfrom
using-sanitize_file_name
Aug 1, 2024
Merged

fix: using sanitize_file_name to generate valid file name#1833
underfin merged 3 commits intomainfrom
using-sanitize_file_name

Conversation

@underfin
Copy link
Contributor

@underfin underfin commented Aug 1, 2024

Description

The rollup using sanitizeFileName to generate the valid file name, see here.

The related vite pr: vitejs/vite#9737.

@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “!merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “!merge-as-hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@netlify
Copy link

netlify bot commented Aug 1, 2024 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit d7663d5
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66ab643be9ceaf000836c62f

@underfin underfin enabled auto-merge (squash) August 1, 2024 10:32
@hyf0 hyf0 disabled auto-merge August 1, 2024 10:37
@underfin underfin merged commit c9f8af4 into main Aug 1, 2024
@underfin underfin deleted the using-sanitize_file_name branch August 1, 2024 10:43
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Benchmarks Rust

group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     48.8±1.97ms        ? ?/sec    1.04     50.9±1.23ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     65.7±1.48ms        ? ?/sec    1.01     66.6±1.15ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     83.2±1.72ms        ? ?/sec    1.03     85.3±3.13ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     57.9±0.90ms        ? ?/sec    1.03     59.8±0.92ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00     90.5±1.21ms        ? ?/sec    1.01     91.3±1.57ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    149.1±5.09ms        ? ?/sec    1.03    153.7±4.73ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    190.9±4.12ms        ? ?/sec    1.05    200.5±5.18ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    109.3±1.50ms        ? ?/sec    1.01    110.5±1.47ms        ? ?/sec
bundle/bundle@threejs                                               1.01     28.0±0.91ms        ? ?/sec    1.00     27.8±1.19ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.01     62.0±2.11ms        ? ?/sec    1.00     61.2±1.75ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00     80.1±1.72ms        ? ?/sec    1.02     81.7±2.86ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     39.2±0.85ms        ? ?/sec    1.00     39.4±0.72ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    293.5±3.48ms        ? ?/sec    1.02    298.5±3.73ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.01    675.1±8.04ms        ? ?/sec    1.00    671.3±7.22ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.02    918.6±9.27ms        ? ?/sec    1.00    903.6±6.36ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    395.9±8.63ms        ? ?/sec    1.01   399.9±10.73ms        ? ?/sec
remapping/remapping                                                 1.00     34.9±0.10ms        ? ?/sec    1.00     35.0±0.19ms        ? ?/sec
remapping/render-chunk-remapping                                    1.01     83.6±0.54ms        ? ?/sec    1.00     82.9±0.40ms        ? ?/sec
scan/scan@rome-ts                                                   1.01     73.4±1.30ms        ? ?/sec    1.00     72.7±1.56ms        ? ?/sec
scan/scan@threejs                                                   1.03     20.5±1.19ms        ? ?/sec    1.00     19.9±0.16ms        ? ?/sec
scan/scan@threejs10x                                                1.02    203.6±1.85ms        ? ?/sec    1.00    199.2±1.95ms        ? ?/sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@underfin @hyf0