Skip to content

feat(error): entry cannot be external#1761

Merged
hyf0 merged 1 commit intomainfrom
07-28-feat_error_entry_cannot_be_external
Jul 27, 2024
Merged

feat(error): entry cannot be external#1761
hyf0 merged 1 commit intomainfrom
07-28-feat_error_entry_cannot_be_external

Conversation

@hyf0
Copy link
Copy Markdown
Member

@hyf0 hyf0 commented Jul 27, 2024

Description

@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Jul 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 27, 2024

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 68b07cc
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66a576472d9cc90008828cb5

@hyf0 hyf0 self-assigned this Jul 27, 2024
@hyf0 hyf0 added this pull request to the merge queue Jul 27, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 27, 2024

Benchmarks Rust

  • target: main(10e8665)
  • pr: 07-28-feat_error_entry_cannot_be_external(68b07cc)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.01     47.5±0.84ms        ? ?/sec    1.00     47.0±0.56ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.03     67.4±1.43ms        ? ?/sec    1.00     65.6±0.81ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     85.5±1.60ms        ? ?/sec    1.00     85.3±1.54ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.02     58.2±0.63ms        ? ?/sec    1.00     56.8±2.08ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00     89.1±1.83ms        ? ?/sec    1.00     88.9±1.28ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    147.5±1.25ms        ? ?/sec    1.00    146.9±1.68ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    192.3±1.76ms        ? ?/sec    1.00    191.7±1.75ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.01    108.6±2.05ms        ? ?/sec    1.00    107.7±0.86ms        ? ?/sec
bundle/bundle@threejs                                               1.00     26.4±0.30ms        ? ?/sec    1.02     26.9±1.79ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     61.1±1.73ms        ? ?/sec    1.00     61.4±1.41ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00     81.2±0.67ms        ? ?/sec    1.00     81.0±0.51ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.02     38.4±0.82ms        ? ?/sec    1.00     37.8±0.39ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    298.0±2.34ms        ? ?/sec    1.00    298.3±2.43ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   903.2±12.60ms        ? ?/sec    1.00    899.0±9.31ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1133.9±12.90ms        ? ?/sec    1.01  1140.5±10.08ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    377.4±4.13ms        ? ?/sec    1.00    376.5±4.81ms        ? ?/sec
remapping/remapping                                                 1.01     34.0±0.12ms        ? ?/sec    1.00     33.7±0.37ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     85.7±0.26ms        ? ?/sec    1.03     87.9±0.50ms        ? ?/sec
scan/scan@rome-ts                                                   1.01     70.4±0.82ms        ? ?/sec    1.00     69.6±0.82ms        ? ?/sec
scan/scan@threejs                                                   1.01     19.4±0.31ms        ? ?/sec    1.00     19.3±0.17ms        ? ?/sec
scan/scan@threejs10x                                                1.00    200.4±2.43ms        ? ?/sec    1.00    200.1±1.35ms        ? ?/sec

Merged via the queue into main with commit b3179e7 Jul 27, 2024
@hyf0 hyf0 deleted the 07-28-feat_error_entry_cannot_be_external branch July 27, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@hyf0 hyf0

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hyf0