feat: support loading dataurl as module.#1741
Merged
hyf0 merged 17 commits intorolldown:mainfrom Jul 27, 2024
Merged
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
7086cmd
commented
Jul 26, 2024
…/dataurl-loading
…ldown into feat/dataurl-loading
Member
|
Thanks for the contribution. I'm gonna make some changes before merging this PR. |
hyf0
approved these changes
Jul 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports functionality from Vite and enables esbuild's tests.
Please note that there is an outstanding issue referenced here that is pending a fix. However, it seems unlikely that this PR will address it, as the complexity of handling the module as an external module again in
load_source.rsis considerable.