Skip to content

fix(rolldown): should correct rewrite path of dynamic imported external modules#1738

Merged
hyf0 merged 1 commit intomainfrom
07-26-fix_rolldown_should_correct_rewrite_path_of_dynamic_imported_external_modules
Jul 25, 2024
Merged

fix(rolldown): should correct rewrite path of dynamic imported external modules#1738
hyf0 merged 1 commit intomainfrom
07-26-fix_rolldown_should_correct_rewrite_path_of_dynamic_imported_external_modules

Conversation

@hyf0
Copy link
Copy Markdown
Member

@hyf0 hyf0 commented Jul 25, 2024 •
edited
Loading

Description

Fixes #1723.

@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Jul 25, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

This was referenced Jul 25, 2024
Merged
Merged
@hyf0 hyf0 marked this pull request as ready for review July 25, 2024 19:52
@hyf0 hyf0 force-pushed the 07-26-test_rust_infra_function-complete_rust_side_tests branch from bf3b69d to 74768db Compare July 25, 2024 19:55
@hyf0 hyf0 force-pushed the 07-26-fix_rolldown_should_correct_rewrite_path_of_dynamic_imported_external_modules branch from 35b5a7d to 4f8c5a0 Compare July 25, 2024 19:55
@hyf0 hyf0 mentioned this pull request Jul 25, 2024
Merged
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 25, 2024 •
edited
Loading

Benchmarks Rust

  • target: main(9b1c632)
  • pr: 07-26-fix_rolldown_should_correct_rewrite_path_of_dynamic_imported_external_modules(5a41b87)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     49.7±1.04ms        ? ?/sec    1.03     51.1±1.37ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.03     70.3±1.51ms        ? ?/sec    1.00     68.3±0.92ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     87.6±0.84ms        ? ?/sec    1.00     87.8±1.59ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.02     60.6±0.89ms        ? ?/sec    1.00     59.3±1.00ms        ? ?/sec
bundle/bundle@rome-ts                                               1.03     94.0±2.41ms        ? ?/sec    1.00     91.0±1.30ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    159.9±2.51ms        ? ?/sec    1.00    159.6±2.95ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    204.2±2.12ms        ? ?/sec    1.00    203.5±3.69ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.02    112.4±0.96ms        ? ?/sec    1.00    110.2±1.90ms        ? ?/sec
bundle/bundle@threejs                                               1.02     28.0±1.07ms        ? ?/sec    1.00     27.4±0.36ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.06     64.7±1.75ms        ? ?/sec    1.00     60.9±1.91ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.04     84.6±1.33ms        ? ?/sec    1.00     81.1±2.29ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     39.0±1.08ms        ? ?/sec    1.01     39.4±0.74ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    305.1±3.54ms        ? ?/sec    1.02    309.8±4.20ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00    920.1±8.06ms        ? ?/sec    1.00    920.6±6.70ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   1155.1±7.72ms        ? ?/sec    1.00  1152.1±13.29ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    384.7±3.41ms        ? ?/sec    1.01    389.6±7.07ms        ? ?/sec
remapping/remapping                                                 1.01     35.3±0.08ms        ? ?/sec    1.00     34.9±0.13ms        ? ?/sec
remapping/render-chunk-remapping                                    1.01     90.0±0.50ms        ? ?/sec    1.00     89.3±0.34ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     71.7±1.07ms        ? ?/sec    1.02     73.1±3.26ms        ? ?/sec
scan/scan@threejs                                                   1.01     19.8±0.46ms        ? ?/sec    1.00     19.6±0.10ms        ? ?/sec
scan/scan@threejs10x                                                1.02    205.4±2.78ms        ? ?/sec    1.00    201.4±1.41ms        ? ?/sec

@hyf0 hyf0 force-pushed the 07-26-test_rust_infra_function-complete_rust_side_tests branch from 74768db to 100c14e Compare July 25, 2024 20:13
@hyf0 hyf0 force-pushed the 07-26-fix_rolldown_should_correct_rewrite_path_of_dynamic_imported_external_modules branch from 4f8c5a0 to 2a8c93c Compare July 25, 2024 20:13
@hyf0 hyf0 self-assigned this Jul 25, 2024
@hyf0 hyf0 force-pushed the 07-26-test_rust_infra_function-complete_rust_side_tests branch from 100c14e to 3963f09 Compare July 25, 2024 20:28
Base automatically changed from 07-26-test_rust_infra_function-complete_rust_side_tests to main July 25, 2024 20:40
@hyf0 hyf0 force-pushed the 07-26-fix_rolldown_should_correct_rewrite_path_of_dynamic_imported_external_modules branch from 2a8c93c to 5a41b87 Compare July 25, 2024 20:41
@hyf0 hyf0 merged commit c682b76 into main Jul 25, 2024
@hyf0 hyf0 deleted the 07-26-fix_rolldown_should_correct_rewrite_path_of_dynamic_imported_external_modules branch July 25, 2024 20:41
@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 25, 2024

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 5a41b87
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66a2b86c849e2600089fbd42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@hyf0 hyf0

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

import is not replaced with resolved id for external dynamic import

1 participant

@hyf0