Skip to content

fix: move banner ahead of the file in cjs format.#1707

Merged
underfin merged 5 commits intorolldown:mainfrom
7086cmd:fix/banner
Jul 24, 2024
Merged

fix: move banner ahead of the file in cjs format.#1707
underfin merged 5 commits intorolldown:mainfrom
7086cmd:fix/banner

Conversation

@7086cmd
Copy link
Contributor

@7086cmd 7086cmd commented Jul 24, 2024

related: #1706, #1705.

Tests are also added.

@netlify
Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 0a0bda9
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66a0bb9812e8fc0008009347

@7086cmd
Copy link
Contributor Author

7086cmd commented Jul 24, 2024

Banner is not supported to be detected inline still. Waiting for another one.

@7086cmd 7086cmd changed the title fix: move banner after use strict in iife format. fix: move banner before use strict in cjs format. Jul 24, 2024
@7086cmd 7086cmd changed the title fix: move banner before use strict in cjs format. fix: move banner ahead of the file in cjs format. Jul 24, 2024
@underfin underfin enabled auto-merge July 24, 2024 08:31
@underfin underfin added this pull request to the merge queue Jul 24, 2024
Merged via the queue into rolldown:main with commit 2640072 Jul 24, 2024
@7086cmd 7086cmd deleted the fix/banner branch July 24, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants