✅ Deploy Preview for rolldown-rs canceled.

I will suggest to inline this package if code is proven to be better. However, in this case, using outside crate is not friendly for future maintaining, if we want to change something.

Ok. How about using the crate's extension_light which can reduce not only the program size but also the bundling time, and ignore other features?

Other implementations are the same as the original one in this repo.

Ok. How about using the crate's extension_light which can reduce not only the program size but also the bundling time, and ignore other features?

Other implementations are the same as the original one in this repo.

If it's better I will suggest just copy those code to rolldown's repo. Using outside crate is not friendly for future maintaining, if we want to change something.

OK, I see.

All snapshot you could found under https://github.com/evanw/esbuild/tree/main/internal/bundler_tests/snapshots, just convert our snake_case into PascalCase and prefix with Test

Okay, thanks. I will fix them when I'm free.

It should be a problem in our test case, and sadly I don't have a way to handle it (indistinguishable file is not supported in GitHub, see it in #1668). In esbuild, the \x should be the transferred expression, for example, when writing

hexString := "\x48\x65\x6C\x6C\x6F"

The hexString is just hello in output.

It should be a problem in our test case, and sadly I don't have a way to handle it (indistinguishable file is not supported in GitHub, see it in #1668). In esbuild, the \x should be the transferred expression, for example, when writing

hexString := "\x48\x65\x6C\x6C\x6F"

The hexString is just hello in output.

Looks like our output is already wrong before https://github.com/rolldown/rolldown/pull/1668/files#diff-d0d7250843734347c76a1838a8e0b2d2f19752da56098bfea90a4e9fc7ac67c0L18,
esbuild

---------- /out.js ----------
// test.custom
var require_test = __commonJS({
  "test.custom"(exports, module) {
    module.exports = "data:application/octet-stream;base64,YQBigGP/ZA==";
  }
});

// entry.js
console.log(require_test());

It should be a problem in our test case, and sadly I don't have a way to handle it (indistinguishable file is not supported in GitHub, see it in #1668). In esbuild, the \x should be the transferred expression, for example, when writing

hexString := "\x48\x65\x6C\x6C\x6F"

The hexString is just hello in output.

Looks like our output is already wrong before https://github.com/rolldown/rolldown/pull/1668/files#diff-d0d7250843734347c76a1838a8e0b2d2f19752da56098bfea90a4e9fc7ac67c0L18, esbuild

---------- /out.js ----------
// test.custom
var require_test = __commonJS({
  "test.custom"(exports, module) {
    module.exports = "data:application/octet-stream;base64,YQBigGP/ZA==";
  }
});

// entry.js
console.log(require_test());

Even if before #1668, the behavior with the test may still be "incorrect" because we may regard every \ as a char instead of the synthesis char with the x00.