Don't smooth velocity after WASD input#11858
Conversation
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
Wumpf
left a comment
There was a problem hiding this comment.
I think this is unfortunately too simplistic: iff the camera position comes from a fallback we want to smooth things out because they can produce jumpy values.
Check for example https://rerun.io/viewer/pr/11858?url=https%3A%2F%2Fapp.rerun.io%2Fversion%2Fnightly%2Fexamples%2Fnuscenes_dataset.rrd which now jumps around a lot
come to think that's actually weird. Shouldn't the smoothed-boundingbox we're using here already do the necessary smoothing? 🤔
also, either way the changed code here could use a comment on why it's important to reset the velocity
|
https://rerun.io/viewer?url=https%3A%2F%2Fapp.rerun.io%2Fversion%2Fnightly%2Fexamples%2Fnuscenes_dataset.rrd also jumps around a lot, and I'm pretty sure we are doing the same smoothing as that. The velocity I set to zero here only affects WASDQE input. Will add a comment though! |
Wumpf
left a comment
There was a problem hiding this comment.
huh you're right. so either this was already broken & nobody cares or I just missrememberd. either way this should go in this case!
Related
What
Stops smoothing down velocity after moving with WASD.
This wasn't written to the blueprint so caused rubber banding that's visible on high speeds.