Skip to content

refactor(lint): Fix lint violations#40965

Merged
viceice merged 2 commits intorenovatebot:mainfrom
zharinov:refactor/fix-lint-violations
Feb 6, 2026
Merged

refactor(lint): Fix lint violations#40965
viceice merged 2 commits intorenovatebot:mainfrom
zharinov:refactor/fix-lint-violations

Conversation

@zharinov
Copy link
Copy Markdown
Collaborator

@zharinov zharinov commented Feb 5, 2026

Changes

Fix underlying lint violations so ESLint passes without disable comments. Remaining suppressions (where the code is correct but lint disagrees) are left for a follow-up.

Comment-only removals

  • Remove /* eslint-disable */ from .markdownlint-cli2.mjs (ESLint doesn't lint this file)

Code fixes

  • Floating promises: void prefix instead of eslint-disable (lib/renovate.ts, tools/generate-schema.ts)
  • Unnecessary async: Remove from helmfile/utils.ts (already returns Promise via localPathExists())
  • Test async patterns: Remove async wrapper in presets/local/index.spec.ts (throws synchronously), replace async arrow with Promise.resolve() in branch/index.spec.ts
  • throw lastError: Add non-null assertion in git/index.ts and bitbucket-server/index.ts (guaranteed set by retry loop)
  • Redundant type constituents: 'local' | (string & {}) preserves autocomplete (config/types.ts)
  • Indexed object style: Replace mapped types with Record<string, ...> (util/stats.ts)

Test fixes

  • no-conditional-expect: Unwind single-element loop in kotlin-script/index.spec.ts; replace manual assertions with Zod schema validation in versioning-metadata.spec.ts
  • no-sparse-arrays: Explicit undefined values in pr/labels.spec.ts
  • no-commented-out-tests: Delete dead commented-out test blocks in codecommit/index.spec.ts
  • no-standalone-expect: Remove unnecessary precondition assertion from git/index.spec.ts beforeAll

Context

  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

  • Yes — substantive assistance

Documentation (please check one with an [x])

  • No documentation update is required

How I've tested my work (please select one)

  • Newly added/modified unit tests

Loading
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants