Skip to content

feat(preset): add preset semverAllWeekly#37562

Merged
secustor merged 4 commits intorenovatebot:mainfrom
cschritt:feat/add-preset-semverallweekly
Aug 29, 2025
Merged

feat(preset): add preset semverAllWeekly#37562
secustor merged 4 commits intorenovatebot:mainfrom
cschritt:feat/add-preset-semverallweekly

Conversation

@cschritt
Copy link
Copy Markdown
Contributor

@cschritt cschritt commented Aug 16, 2025

Changes

Added the preset semverAllWeekly

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@cschritt cschritt changed the title add preset semverAllWeekly feat(preset): add preset semverAllWeekly Aug 16, 2025
viceice
viceice reviewed Aug 18, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see much value of those presets

@viceice viceice requested review from rarkins and secustor August 18, 2025 16:57
secustor
secustor reviewed Aug 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be very specific tailored to your use case, why do you think this should be in the build in presets?

If it is that about that you do not want to add those extends in every of your repositories, are you aware of self hosted presets?

@cschritt
Copy link
Copy Markdown
Contributor Author

cschritt commented Aug 29, 2025 •
edited
Loading

Thanks for your feedback. I clearly should have explained my motivation for this change.
I came accross the preset config:semverAllMonthly recently and thought that this could also make sense on a weekly schedule. We also already have schedule:weekly and :maintainLockFilesWeekly, so it might also make sense to be consistent with the 'monthly' presets we already have.

secustor
secustor approved these changes Aug 29, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve, as it makes sense from a consistency perspective.

@secustor secustor added this pull request to the merge queue Aug 29, 2025
Merged via the queue into renovatebot:main with commit f2e3ae2 Aug 29, 2025
40 checks passed
ducthinh993 pushed a commit to ducthinh993/renovate that referenced this pull request Sep 11, 2025
@cschritt @ducthinh993
feat(preset): add preset semverAllWeekly (renovatebot#37562)
42b8e3a
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@viceice viceice viceice left review comments

@secustor secustor secustor approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cschritt @viceice @secustor