Skip to content

fix(git): remotes sync#36180

Merged
rarkins merged 6 commits intomainfrom
fix/sync-remotes
May 27, 2025
Merged

fix(git): remotes sync#36180
rarkins merged 6 commits intomainfrom
fix/sync-remotes

Conversation

@rarkins
Copy link
Copy Markdown
Contributor

@rarkins rarkins commented May 27, 2025

Changes

Refactors fork syncing logic to avoid errors when:

  • git isn't sync'd yet (due to repository cache)
  • simplegit attempts to fetch the list of remotes

Context

#36142

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Copy Markdown
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test failures

@rarkins rarkins requested a review from viceice May 27, 2025 13:46
@rarkins rarkins enabled auto-merge May 27, 2025 13:46
Comment thread lib/util/git/index.ts Outdated
Copy link
Copy Markdown
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

rarkins and others added 2 commits May 27, 2025 18:24
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@rarkins rarkins added this pull request to the merge queue May 27, 2025
Merged via the queue into main with commit dffabcb May 27, 2025
40 checks passed
@rarkins rarkins deleted the fix/sync-remotes branch May 27, 2025 16:57
@renovate-release
Copy link
Copy Markdown

🎉 This PR is included in version 40.33.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants