Skip to content

fix(dashboard): don't show undefined being displayed#36132

Merged
rarkins merged 1 commit intorenovatebot:mainfrom
Mic92:undefined-dashboard
May 26, 2025
Merged

fix(dashboard): don't show undefined being displayed#36132
rarkins merged 1 commit intorenovatebot:mainfrom
Mic92:undefined-dashboard

Conversation

@Mic92
Copy link
Copy Markdown
Contributor

@Mic92 Mic92 commented May 25, 2025

With nix, we don't always have a version or digest for dependencies.

This is part of #33991

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@Mic92
Copy link
Copy Markdown
Contributor Author

Mic92 commented May 25, 2025

One test failure which looks like it's flaky to me. Otherwise it seems fine.


⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Failed Tests 1 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯

 FAIL  lib/config/decrypt/kbpgp.spec.ts > config/decrypt/kbpgp > decryptConfig() > rejects invalid PGP message
Error: Test timed out in 5000ms.
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".
 ❯ lib/config/decrypt/kbpgp.spec.ts:30:5
     28|     });
     29|
     30|     it('rejects invalid PGP message', async () => {
       |     ^
     31|       setPrivateKeys(privateKey, undefined);
     32|       config.encrypted = {

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯

 Test Files  1 failed | 808 passed (809)
      Tests  1 failed | 18497 passed | 1 skipped (18499)
   Start at  11:35:58
   Duration  202.06s (transform 33.72s, setup 358.12s, collect 1613.26s, tests 238.31s, environment 371ms, prepare 139.79s)

 ELIFECYCLE  Command failed with exit code 1.
ERROR: "jest" exited with 1.
 ELIFECYCLE  Test failed. See above for more details.
pnpm test  2163.18s user 288.66s system 980% cpu 4:09.98 total

Copy link
Copy Markdown
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs tests

Comment thread lib/workers/repository/package-files.ts Outdated
With nix, we don't always have a version or digest for dependencies.
@Mic92 Mic92 force-pushed the undefined-dashboard branch from dd65b2d to a96639d Compare May 25, 2025 13:15
@viceice viceice requested a review from rarkins May 26, 2025 07:23
@rarkins rarkins added this pull request to the merge queue May 26, 2025
Merged via the queue into renovatebot:main with commit 0619849 May 26, 2025
40 checks passed
@renovate-release
Copy link
Copy Markdown

🎉 This PR is included in version 40.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants