Skip to content

fix(manager/fleet): Make name optional for target customizations in FleetFile schema#36085

Merged
rarkins merged 7 commits intorenovatebot:mainfrom
akdb-devops:fix-optional-name
May 24, 2025
Merged

fix(manager/fleet): Make name optional for target customizations in FleetFile schema#36085
rarkins merged 7 commits intorenovatebot:mainfrom
akdb-devops:fix-optional-name

Conversation

@another-novelty
Copy link
Copy Markdown
Contributor

@another-novelty another-novelty commented May 22, 2025

Changes

Target customizations for fleet do not actually need a name (see https://fleet.rancher.io/ref-fleet-yaml). This PR makes the name in the schema optional and generates a dependency name if none is provided by the fleet.yaml.

Context

  • #36022

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 22, 2025

CLA assistant check
All committers have signed the CLA.

@another-novelty another-novelty changed the title Make name optional for target customizations in FleetFile schema fix: Make name optional for target customizations in FleetFile schema May 22, 2025
@another-novelty another-novelty changed the title fix: Make name optional for target customizations in FleetFile schema fix(manager/fleet): Make name optional for target customizations in FleetFile schema May 22, 2025
Copy link
Copy Markdown
Collaborator

@RahulGautamSingh RahulGautamSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread lib/modules/manager/fleet/extract.ts Outdated
Comment thread lib/modules/manager/fleet/extract.ts Outdated
Comment thread lib/modules/manager/fleet/extract.ts Outdated
another-novelty and others added 2 commits May 22, 2025 17:09
Co-authored-by: Rhys Arkins <rhys@arkins.net>
@another-novelty another-novelty requested a review from rarkins May 22, 2025 15:26
Comment thread lib/modules/manager/fleet/extract.ts Outdated
@another-novelty another-novelty requested a review from viceice May 23, 2025 12:30
@rarkins rarkins added this pull request to the merge queue May 24, 2025
Merged via the queue into renovatebot:main with commit 90d8b7d May 24, 2025
40 checks passed
@renovate-release
Copy link
Copy Markdown

🎉 This PR is included in version 40.27.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants