fix(manager/npm): search for npmrc in the root directory#36050
Merged
rarkins merged 5 commits intorenovatebot:mainfrom May 29, 2025
lpriyasivakumar:fix/npmrc-check
Merged
fix(manager/npm): search for npmrc in the root directory#36050rarkins merged 5 commits intorenovatebot:mainfrom lpriyasivakumar:fix/npmrc-check
rarkins merged 5 commits intorenovatebot:mainfrom
lpriyasivakumar:fix/npmrc-check
Conversation
Contributor
Author
|
@rarkins Raised the PR again as requested. Would love to know how I can improve the fix without breaking functionality. Ty! |
Contributor
|
One thing we need to fix is that Renovate should not write out to disk the workspace .npmrc file to all workspaces |
Contributor
Author
rarkins
approved these changes
May 29, 2025
|
🎉 This PR is included in version 40.35.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The .npmrc file was searched for as a sibling of a package file. With this change, .npmrc will be detected and applied if it is at the root of the repository. This is how pnpm reads the .npmrc file in mono repos.
Clarified by pnpm contributors here
Context
We currently have teams that have a nested mono-repo structure. In these repos, renovate does not correctly use our internal registry url to fetch internal and scoped packages. The bug is described with reproduction and logs in this discussion thread.
#35926
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: