Skip to content

fix(versioning/ruby): prevent extra vv prefix addition#35667

Merged
rarkins merged 2 commits intorenovatebot:mainfrom
RahulGautamSingh:fix-35494
May 1, 2025
Merged

fix(versioning/ruby): prevent extra vv prefix addition#35667
rarkins merged 2 commits intorenovatebot:mainfrom
RahulGautamSingh:fix-35494

Conversation

@RahulGautamSingh
Copy link
Copy Markdown
Collaborator

@RahulGautamSingh RahulGautamSingh commented May 1, 2025 •
edited
Loading

Changes

Modified the if check in getNewValue funciton so it only adds a v to the new value being computed if:
a) currrentValue has v preifx
b) newVersion doesn't have v prefix

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

viceice
viceice reviewed May 1, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also check docker versioning, it can flipping the v prefix if both tags are available. can be tested with traefik image

Comment thread lib/modules/versioning/ruby/index.ts Outdated
@RahulGautamSingh
Copy link
Copy Markdown
Collaborator Author

RahulGautamSingh commented May 1, 2025

we should also check docker versioning, it can flipping the v prefix if both tags are available. can be tested with traefik image

Seems to be working fine https://github.com/Rahul-renovate-testing/v-prefix-docker/pull/1/files

@RahulGautamSingh RahulGautamSingh requested a review from viceice May 1, 2025 15:53
@viceice
Copy link
Copy Markdown
Member

viceice commented May 1, 2025

we should also check docker versioning, it can flipping the v prefix if both tags are available. can be tested with traefik image

Seems to be working fine https://github.com/Rahul-renovate-testing/v-prefix-docker/pull/1/files

use the three part tags

@RahulGautamSingh
Copy link
Copy Markdown
Collaborator Author

RahulGautamSingh commented May 1, 2025 •
edited
Loading

use the three part tags

Rahul-renovate-testing/v-prefix-docker#3 if v prefix present it stays
Rahul-renovate-testing/v-prefix-docker#4 if v prefix absent it is being added

Created a new issue out of it to prevent the v prefix from being added when it's not originally present..

@rarkins rarkins added this pull request to the merge queue May 1, 2025
Merged via the queue into renovatebot:main with commit 7314557 May 1, 2025
40 checks passed
@renovate-release
Copy link
Copy Markdown

renovate-release commented May 1, 2025

🎉 This PR is included in version 40.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bundler: git dependency tag update adds extra "v" (v13 -> vv14)

4 participants

@RahulGautamSingh @viceice @renovate-release @rarkins