fix(memCache): disallow http requests in cache to be mutable#35647
Merged
rarkins merged 1 commit intorenovatebot:mainfrom Apr 30, 2025
Merged
fix(memCache): disallow http requests in cache to be mutable#35647rarkins merged 1 commit intorenovatebot:mainfrom
rarkins merged 1 commit intorenovatebot:mainfrom
Conversation
zharinov
approved these changes
Apr 30, 2025
viceice
approved these changes
Apr 30, 2025
Member
viceice
left a comment
There was a problem hiding this comment.
this causes performance, not sure if it's measurable. 🤔
Contributor
Author
Yeah, but the side effect without it is a lot worse. |
|
🎉 This PR is included in version 40.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
SuperSandro2000
added a commit
to SuperSandro2000/renovate
that referenced
this pull request
May 1, 2025
* upstream/main: (176 commits) build(deps): update aws-sdk-js-v3 monorepo (main) (renovatebot#35660) chore(deps): update docker/dockerfile docker tag to v1.15.1 (main) (renovatebot#35659) fix(deps): update ghcr.io/renovatebot/base-image docker tag to v9.64.3 (main) (renovatebot#35657) chore: thre -> the (renovatebot#35655) chore(deps): update dependency vite to v6.3.4 [security] (main) (renovatebot#35653) build(deps): update dependency glob to v11.0.2 (main) (renovatebot#35649) fix(memCache): disallow http requests in cache to be mutable (renovatebot#35647) fix(gomod): Exclude multi-line `exclude` directives from extraction (renovatebot#35623) docs(config options): rewrite `ignoreScripts` (renovatebot#32171) chore(deps): update python:3.13 docker digest to 884da97 (main) (renovatebot#35645) chore(deps): update python docker tag to v3.13.3 (main) (renovatebot#35276) fix(deps): update ghcr.io/renovatebot/base-image docker tag to v9.64.2 (main) (renovatebot#35644) feat(config)!: validate allowedCommands against post-compiled commands (renovatebot#35564) feat(config)!: create new Config Warning issues each time (renovatebot#35565) feat(autodiscoverFilter)!: support combined negative matches (renovatebot#34707) feat(datasource/maven)!: use latest and release values as tags (renovatebot#35515) feat!: require node v22.13 (renovatebot#34524) chore(deps): update dependency esbuild to v0.25.3 (main) (renovatebot#35637) chore(deps): update python:3.13 docker digest to 19c3e96 (main) (renovatebot#35636) feat(deps): update ghcr.io/renovatebot/base-image docker tag to v9.64.1 (main) (renovatebot#35632) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes an issue with the memoery http cache provider where the cached http reponses could be mutated after being read from the cache.
This could cause several unexected issues, like returning a cache hit with a different body than the one that was cached.
So far, only the Gerrit platform was identified as being affected by this issue.
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: