fix(manager/gomod): use regex to remove version suffix from name#35508
Merged
rarkins merged 2 commits intorenovatebot:mainfrom Apr 23, 2025
Merged
fix(manager/gomod): use regex to remove version suffix from name#35508rarkins merged 2 commits intorenovatebot:mainfrom
rarkins merged 2 commits intorenovatebot:mainfrom
Conversation
rarkins
approved these changes
Apr 23, 2025
viceice
reviewed
Apr 24, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR uses a regular expression to remove the
/v2or/v3suffix from go packages. This is later used to determine if suffix can be updated or appended.Context
The change is required for packages which don't contain a
org/repobut only a package name likesigs.k8s.io/structured-merge-diff. Currently Renovate appends here the new major version to construct the wrongsigs.k8s.io/structured-merge-diff/v4/v6rather than the expectedsigs.k8s.io/structured-merge-diff/v6fixes #35507
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
Tests are added both for the short example as well as an example with multiple (3+) name components.