Skip to content

feat(pixi)!: add feature to depType#35255

Merged
rarkins merged 8 commits intorenovatebot:mainfrom
trim21:pixi/dep-type
Jun 19, 2025
Merged

feat(pixi)!: add feature to depType#35255
rarkins merged 8 commits intorenovatebot:mainfrom
trim21:pixi/dep-type

Conversation

@trim21
Copy link
Copy Markdown
Contributor

@trim21 trim21 commented Apr 8, 2025 •
edited by viceice
Loading

Changes

add feature name to depType so users can match package by feature name.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

rarkins
rarkins reviewed Apr 8, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is technically a breaking change for any existing pixi users who rely on matching this depType. Should we wait for a major Renovate release or do we think this is OK to "break" in a non-major?

@trim21
Copy link
Copy Markdown
Contributor Author

trim21 commented Apr 8, 2025

Should we wait for a major Renovate release?

Any ETA on next major release?

Currently depType provide almost zero extra information on matching package and pixi is just online for 1 day, I think the effect would be very small.

But I'm ok to wait until next major version.

@rarkins
Copy link
Copy Markdown
Contributor

rarkins commented Apr 8, 2025

v40 is likely within the next month

@trim21 trim21 changed the title fix(pixi): add feature to depType feat(pixi)!: add feature to depType Apr 8, 2025
@trim21
Copy link
Copy Markdown
Contributor Author

trim21 commented Apr 8, 2025

let's hope no users add new packageRules to match depType on pixi manager in this month

@trim21 trim21 changed the base branch from main to next April 8, 2025 14:33
@trim21 trim21 changed the base branch from next to main April 8, 2025 14:34
@trim21
Copy link
Copy Markdown
Contributor Author

trim21 commented Apr 8, 2025 •
edited
Loading

Then how should I submit this PR? 😅

Should I rebase on next branch and change base?
Or just wait until we merge next in to main?

This was referenced Apr 9, 2025
Closed
Closed
@trim21
Copy link
Copy Markdown
Contributor Author

trim21 commented May 4, 2025

v40 is likely within the next month

hi, I saw v40 is already released?

@rarkins rarkins added the breaking Breaking change, requires major version bump label May 4, 2025
@trim21 trim21 requested a review from rarkins May 4, 2025 18:51
@viceice viceice added this to the v41 milestone May 9, 2025
@lucascolley
Copy link
Copy Markdown

lucascolley commented May 16, 2025

as a point of user feedback after using renovate with Pixi for a few weeks now, this is the only unresolved problem I have experienced so far! Would be great if this could make it into the next release.

@rarkins rarkins merged commit 0b676d7 into renovatebot:main Jun 19, 2025
40 checks passed
@lucascolley
Copy link
Copy Markdown

lucascolley commented Jun 19, 2025

Thank you @rarkins ! I will test out this PR once it is released and send feedback if I hit any issues

@trim21 trim21 deleted the pixi/dep-type branch June 19, 2025 09:45
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@rarkins rarkins rarkins approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

breaking Breaking change, requires major version bump

Projects

None yet

Milestone

v41

Development

Successfully merging this pull request may close these issues.

4 participants

@trim21 @rarkins @lucascolley @viceice