Skip to content

feat(autodiscoverFilter)!: support combined negative matches#34707

Merged
rarkins merged 4 commits intomainfrom
feat/21347-autodiscoverfilter-multiple-exclusions
Apr 30, 2025
Merged

feat(autodiscoverFilter)!: support combined negative matches#34707
rarkins merged 4 commits intomainfrom
feat/21347-autodiscoverfilter-multiple-exclusions

Conversation

@rarkins
Copy link
Copy Markdown
Contributor

@rarkins rarkins commented Mar 9, 2025

Changes

Migrates autodiscoverFilter to use Renovate's common matchRegexOrGlob capability, therefore allowing one or more negative filters to be used compatibly with positive filters.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins added the breaking Breaking change, requires major version bump label Mar 9, 2025
@rarkins rarkins requested review from secustor and viceice March 9, 2025 06:34
@rarkins
Copy link
Copy Markdown
Contributor Author

rarkins commented Mar 9, 2025

Probably should be rebased against Next?

Copy link
Copy Markdown
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it needs to be rebased onto next.

Comment thread docs/usage/self-hosted-configuration.md Outdated
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Copy link
Copy Markdown
Member

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but should target v40

@viceice viceice added this to the v40 milestone Mar 9, 2025
@rarkins rarkins changed the base branch from main to next April 27, 2025 07:37
@rarkins rarkins requested review from secustor and viceice April 27, 2025 07:40
@rarkins rarkins changed the base branch from next to main April 27, 2025 09:47
@rarkins rarkins changed the base branch from main to next April 27, 2025 09:48
@rarkins rarkins force-pushed the feat/21347-autodiscoverfilter-multiple-exclusions branch from f68d221 to b1adfa7 Compare April 27, 2025 09:50
@rarkins rarkins changed the base branch from next to main April 27, 2025 09:50
@rarkins rarkins merged commit a77a429 into main Apr 30, 2025
40 checks passed
@rarkins rarkins deleted the feat/21347-autodiscoverfilter-multiple-exclusions branch April 30, 2025 08:52
@renovate-release
Copy link
Copy Markdown

🎉 This PR is included in version 40.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@szpak
Copy link
Copy Markdown
Contributor

szpak commented Apr 30, 2025

It's already merged, but the idea came to my mind to write a test for the case:

  "autodiscoverFilter": ["my-org/*", "!my-org/old-*", "my-org/old-projects/this-one-still-active"]

Whether this-one-still-active will be analyzed or not.

SuperSandro2000 added a commit to SuperSandro2000/renovate that referenced this pull request May 1, 2025
* upstream/main: (176 commits)
  build(deps): update aws-sdk-js-v3 monorepo (main) (renovatebot#35660)
  chore(deps): update docker/dockerfile docker tag to v1.15.1 (main) (renovatebot#35659)
  fix(deps): update ghcr.io/renovatebot/base-image docker tag to v9.64.3 (main) (renovatebot#35657)
  chore: thre -> the (renovatebot#35655)
  chore(deps): update dependency vite to v6.3.4 [security] (main) (renovatebot#35653)
  build(deps): update dependency glob to v11.0.2 (main) (renovatebot#35649)
  fix(memCache): disallow http requests in cache to be mutable (renovatebot#35647)
  fix(gomod): Exclude multi-line `exclude` directives from extraction (renovatebot#35623)
  docs(config options): rewrite `ignoreScripts` (renovatebot#32171)
  chore(deps): update python:3.13 docker digest to 884da97 (main) (renovatebot#35645)
  chore(deps): update python docker tag to v3.13.3 (main) (renovatebot#35276)
  fix(deps): update ghcr.io/renovatebot/base-image docker tag to v9.64.2 (main) (renovatebot#35644)
  feat(config)!: validate allowedCommands against post-compiled commands (renovatebot#35564)
  feat(config)!: create new Config Warning issues each time (renovatebot#35565)
  feat(autodiscoverFilter)!: support combined negative matches (renovatebot#34707)
  feat(datasource/maven)!: use latest and release values as tags (renovatebot#35515)
  feat!: require node v22.13 (renovatebot#34524)
  chore(deps): update dependency esbuild to v0.25.3 (main) (renovatebot#35637)
  chore(deps): update python:3.13 docker digest to 19c3e96 (main) (renovatebot#35636)
  feat(deps): update ghcr.io/renovatebot/base-image docker tag to v9.64.1 (main) (renovatebot#35632)
  ...
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

breaking Breaking change, requires major version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add autodiscoverExclusions to exclude projects fetched by autodiscoverFilter

5 participants