Skip to content

fix(lib/config/decrypt): support azure collection matching#34215

Merged
rarkins merged 12 commits intomainfrom
nabeel-decryp-azdo-v2
Mar 3, 2025
Merged

fix(lib/config/decrypt): support azure collection matching#34215
rarkins merged 12 commits intomainfrom
nabeel-decryp-azdo-v2

Conversation

@nabeelsaabna
Copy link
Copy Markdown
Contributor

@nabeelsaabna nabeelsaabna commented Feb 13, 2025 •
edited
Loading

Changes

For azure the higher level org (collection) is part of the endpoint and encrypted tokens can't be created for a full org

example:

platform: azure
endpoint: https://dev.azure.com/nabeelsaabna
repository: renovate-test/token-decrypt
org repo current new
renovate-test token-decrypt match match
renovate-test match match
nabeelsaabna/renovate-test token-decrypt no match match
nabeelsaabna/renovate-test no match match
nabeelsaabna no match not match
nabeelsaabna/* no match match

updated

Context

recreated for CLA and email issue #34205

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@nabeelsaabna nabeelsaabna mentioned this pull request Feb 13, 2025
Closed
6 tasks
@nabeelsaabna nabeelsaabna marked this pull request as ready for review February 13, 2025 17:41
rarkins
rarkins reviewed Feb 14, 2025
View reviewed changes
Comment thread lib/config/decrypt.ts Outdated
Comment thread lib/config/decrypt.spec.ts
rarkins
rarkins reviewed Feb 14, 2025
View reviewed changes
Comment thread lib/config/decrypt.spec.ts Outdated
@nabeelsaabna nabeelsaabna requested a review from rarkins February 14, 2025 09:49
@viceice
Copy link
Copy Markdown
Member

viceice commented Feb 16, 2025

please force push to old branch next time, so we don't loose review history

viceice
viceice requested changes Feb 16, 2025
View reviewed changes
Comment thread lib/config/decrypt.ts Outdated
Comment thread lib/config/decrypt.ts Outdated
@nabeelsaabna nabeelsaabna requested a review from viceice February 17, 2025 06:15
rarkins
rarkins previously approved these changes Feb 25, 2025
View reviewed changes
viceice
viceice reviewed Feb 25, 2025
View reviewed changes
Comment thread lib/config/decrypt.spec.ts
viceice
viceice reviewed Feb 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

viceice
viceice previously approved these changes Feb 25, 2025
View reviewed changes
@rarkins rarkins enabled auto-merge February 25, 2025 19:34
@nabeelsaabna nabeelsaabna dismissed stale reviews from rarkins and viceice via 06a7c08 March 3, 2025 11:23
@nabeelsaabna nabeelsaabna requested review from rarkins and viceice March 3, 2025 11:24
@rarkins rarkins added this pull request to the merge queue Mar 3, 2025
Merged via the queue into main with commit a39108a Mar 3, 2025
@rarkins rarkins deleted the nabeel-decryp-azdo-v2 branch March 3, 2025 11:51
@renovate-release
Copy link
Copy Markdown

renovate-release commented Mar 3, 2025

🎉 This PR is included in version 39.185.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@viceice viceice viceice approved these changes

+1 more reviewer

@rarkins rarkins rarkins approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nabeelsaabna @viceice @renovate-release @rarkins