feat: add generic bumpVersions option by secustor · Pull Request #34023 · renovatebot/renovate

secustor · 2025-02-04T09:56:35Z

Changes

Implements bumpVersions which leans the semantics of our custom managers

Context

Closes #28045

Documentation (please check one with an [x])

I have updated the documentation, or
No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

Code inspection only, or
Newly added/modified unit tests, or
No unit tests but ran on a real repository, or
Both unit tests + ran on a real repository

https://github.com/secustor/renovate-bump-versions

# Conflicts: # lib/config/options/index.ts # lib/workers/repository/update/branch/get-updated.ts

viceice

LGTM, but does it bump the version in every update PR? I see no filter to limit it.

As far as i can see if i configure it for a specific file (eg Chart.yaml for values.yaml updates), then it will bump it even for updates on workflows?
Shouldn't we limit this to specifix updates somehow? can it be used in package rules? i don't see it in docs.

viceice · 2025-03-05T16:11:55Z

will be conflicted with #34615

secustor · 2025-03-05T19:14:19Z

LGTM, but does it bump the version in every update PR? I see no filter to limit it.

As far as i can see if i configure it for a specific file (eg Chart.yaml for values.yaml updates), then it will bump it even for updates on workflows? Shouldn't we limit this to specifix updates somehow? can it be used in package rules? i don't see it in docs.

This would be the case if you configure it in the root.
For such cases people can use packageRules e.g. with matchFileNames. I have added an example to the reproduction

viceice

otherwisew LGTM

…e field

secustor · 2025-05-04T23:26:10Z

I had to change to change the logic a bit, to ensure the order of FileChanges

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

renovate-release · 2025-05-06T13:41:31Z

🎉 This PR is included in version 40.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

secustor added 10 commits January 30, 2025 01:45

feat(bumpVersions): first working version

aff3619

feat(bumpVersions): allow fileMatch in bumpVersions

856c794

refactor: move bumpPackageVersion to a separate function

92d31d1

fix: do not flip when reusing branch

0579115

Merge branch 'main' into feat/bump-versions

d09128b

# Conflicts: # lib/config/options/index.ts # lib/workers/repository/update/branch/get-updated.ts

docs(bumpVersions): add docs

43fe66f

fix(bumpVersions): do not run bumpVersion if empty array

04c857b

chore(bumpVersions): prettier

537b74e

feat(bumpVersions): add tests and small improvements

52be283

revert automatically changed lines

d256ff9

secustor requested review from rarkins and viceice February 4, 2025 09:56

viceice reviewed Feb 4, 2025

View reviewed changes

Comment thread lib/config/options/index.ts

Comment thread lib/workers/repository/update/branch/bump-versions.spec.ts Outdated

Comment thread lib/workers/repository/update/branch/bump-versions.ts

Comment thread lib/workers/repository/update/branch/index.ts Outdated

implement suggestions

cb63f34

secustor requested a review from viceice February 4, 2025 21:44

secustor mentioned this pull request Feb 11, 2025

refactor: use record for artifactUpdates #34138

Closed

6 tasks

secustor and others added 2 commits February 26, 2025 22:07

Merge branch 'main' into feat/bump-versions

7ce4ee2

tests: migrate to vitest

e9c7c3a

viceice reviewed Mar 5, 2025

View reviewed changes

Comment thread lib/workers/repository/update/branch/bump-versions.spec.ts Outdated

secustor added 2 commits March 5, 2025 19:59

Merge branch 'main' into feat/bump-versions

bddf4b1

remove unnecessary spyOn and add extra docs

c306cb7

secustor force-pushed the feat/bump-versions branch from 80446ba to c306cb7 Compare March 5, 2025 19:13

secustor requested a review from viceice March 5, 2025 19:14

viceice reviewed Mar 6, 2025

View reviewed changes

Comment thread lib/workers/repository/update/branch/bump-versions.spec.ts Outdated

Comment thread lib/workers/repository/update/branch/bump-versions.spec.ts Outdated

add suggestions

301a4cb

secustor enabled auto-merge March 6, 2025 23:56

secustor requested a review from viceice March 6, 2025 23:57

astellingwerf suggested changes Mar 26, 2025

View reviewed changes

Comment thread docs/usage/configuration-options.md

Comment thread lib/config/options/index.ts

astellingwerf suggested changes Mar 26, 2025

View reviewed changes

Comment thread docs/usage/configuration-options.md Outdated

Comment thread docs/usage/configuration-options.md Outdated

Comment thread lib/config/options/index.ts Outdated

Comment thread docs/usage/configuration-options.md Outdated

Comment thread docs/usage/configuration-options.md Outdated

astellingwerf reviewed Mar 26, 2025

View reviewed changes

Comment thread lib/config/validation.ts Outdated

viceice reviewed Apr 1, 2025

View reviewed changes

okgolove mentioned this pull request Apr 12, 2025

feat: rework helm chart OliveTin/OliveTin-HelmChart#4

Merged

LeoColomb mentioned this pull request May 3, 2025

Helm dependencies should optionally bump chart.yaml #4728

Open

secustor added 4 commits May 4, 2025 13:17

Merge branch 'main' into feat/bump-versions

2593101

refactor(bump-versions): rename fileMatch to filePatterns and add nam…

3c9c7d4

…e field

docs(bump-versions): update docs

899de89

ensure order of changes, improve testing

73afa26

secustor requested a review from viceice May 4, 2025 23:24

astellingwerf reviewed May 5, 2025

View reviewed changes

Comment thread docs/usage/configuration-options.md Outdated

apply suggestions

3593b85

viceice reviewed May 6, 2025

View reviewed changes

Comment thread lib/config/validation.spec.ts Outdated

Comment thread lib/workers/repository/update/branch/bump-versions.spec.ts Outdated

Comment thread lib/workers/repository/update/branch/bump-versions.ts

secustor and others added 3 commits May 6, 2025 14:52

Apply suggestions from code review

68b2547

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

indent other codeblocks

093a361

remove vitest import

dc75922

secustor requested a review from viceice May 6, 2025 13:06

viceice approved these changes May 6, 2025

View reviewed changes

secustor added this pull request to the merge queue May 6, 2025

Merged via the queue into renovatebot:main with commit c4a2862 May 6, 2025
40 checks passed

secustor deleted the feat/bump-versions branch May 6, 2025 13:24

LeoColomb mentioned this pull request May 6, 2025

Leverage Renovate new bumpVersions option netbox-community/netbox-chart#651

Closed

JuniorJPDJ mentioned this pull request May 6, 2025

Migrate from bump-chart-version.sh to native renovate bumpVersions JuniorJPDJ/charts#485

Open

cjedro mentioned this pull request May 12, 2025

fix renovate config, bump appVersion and version in Chart.yaml cloudeteer/helm-charts#16

Merged

TheMeier reviewed May 14, 2025

View reviewed changes

Comment thread docs/usage/configuration-options.md

github-actions Bot locked as resolved and limited conversation to collaborators Jun 14, 2025

Conversation

secustor commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Context

Documentation (please check one with an [x])

How I've tested my work (please select one)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

viceice left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

viceice commented Mar 5, 2025

Uh oh!

secustor commented Mar 5, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

viceice left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

secustor commented May 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

renovate-release commented May 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

secustor commented Feb 4, 2025 •

edited

Loading