Skip to content

feat(manager): add renovate config presets manager#32688

Merged
rarkins merged 34 commits intorenovatebot:mainfrom
risu729:feat/renovate-config-presets-manager
Apr 21, 2025
Merged

feat(manager): add renovate config presets manager#32688
rarkins merged 34 commits intorenovatebot:mainfrom
risu729:feat/renovate-config-presets-manager

Conversation

@risu729
Copy link
Copy Markdown
Contributor

@risu729 risu729 commented Nov 23, 2024 •
edited by viceice
Loading

Changes

Adds Renovate config presets manager.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@risu729
Copy link
Copy Markdown
Contributor Author

risu729 commented Nov 23, 2024

I'm not really sure about the code structure, but it seems I can't rely on config/presets/ in managers.
Should I rewrite the manager with regex?

@rarkins
Copy link
Copy Markdown
Contributor

rarkins commented Dec 5, 2024

I'm not really sure about the code structure, but it seems I can't rely on config/presets/ in managers. Should I rewrite the manager with regex?

You can try refactoring the parsePreset(input: string): ParsedPreset function in lib/config/presets/index.ts to lib/config/presets/parse.ts as an effort to break the circulate dependency

@risu729
Copy link
Copy Markdown
Contributor Author

risu729 commented Dec 5, 2024

Thank you for your advice! I refactored and the circular dependencies were resolved.

@rarkins rarkins self-requested a review December 6, 2024 09:24
viceice
viceice reviewed Dec 9, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please create a separate refactor PR to be merged first. 🤗

viceice
viceice reviewed Dec 9, 2024
View reviewed changes
Comment thread lib/modules/manager/renovate-config-presets/extract.spec.ts Outdated
Comment thread lib/modules/manager/renovate-config-presets/extract.ts Outdated
Comment thread lib/modules/manager/renovate-config-presets/extract.ts Outdated
Comment thread lib/modules/manager/renovate-config-presets/index.ts
@risu729 risu729 mentioned this pull request Dec 11, 2024
Merged
6 tasks
@risu729
Copy link
Copy Markdown
Contributor Author

risu729 commented Dec 11, 2024

please create a separate refactor PR to be merged first. 🤗

Sorry for refactoring in the same PR.
I opened #33036. Could you take a look when you have a moment?

@risu729 risu729 mentioned this pull request Jan 2, 2025
Merged
@rarkins rarkins requested a review from viceice February 2, 2025 06:58
viceice
viceice reviewed Mar 6, 2025
View reviewed changes
Comment thread lib/modules/manager/renovate-config-presets/readme.md
Comment thread lib/modules/manager/renovate-config-presets/extract.ts Outdated
@risu729 risu729 requested a review from viceice March 17, 2025 17:25
viceice
viceice reviewed Mar 18, 2025
View reviewed changes
Comment thread lib/modules/manager/renovate-config-presets/extract.ts Outdated
Comment thread lib/modules/manager/renovate-config-presets/extract.ts Outdated
viceice
viceice reviewed Apr 2, 2025
View reviewed changes
Comment thread lib/modules/manager/renovate-config-presets/readme.md
@risu729 @viceice
docs: add about extends in sub objects
33c459e 
Co-authored-by: Michael Kriese <michael.kriese@gmx.de>
@rarkins rarkins requested a review from viceice April 3, 2025 04:56
@rarkins rarkins added this pull request to the merge queue Apr 21, 2025
Merged via the queue into renovatebot:main with commit d8e0f4b Apr 21, 2025
40 checks passed
@renovate-release
Copy link
Copy Markdown

renovate-release commented Apr 21, 2025

🎉 This PR is included in version 39.253.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@risu729 risu729 deleted the feat/renovate-config-presets-manager branch April 21, 2025 05:33
@risu729
Copy link
Copy Markdown
Contributor Author

risu729 commented Apr 21, 2025

Thanks for the review and merging!

@Milanhe92
Copy link
Copy Markdown

Milanhe92 commented Apr 21, 2025

https://x.com/Milanhe1992 #15

rarkins added a commit that referenced this pull request Apr 23, 2025
@rarkins
Revert "feat(manager): add renovate config presets manager (#32688)"
44eb8b3 
This reverts commit d8e0f4b.
@rarkins rarkins mentioned this pull request Apr 23, 2025
Merged
@risu729 risu729 mentioned this pull request Apr 25, 2025
Merged
6 tasks
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Renovate Preset Config Manager

5 participants

@risu729 @rarkins @renovate-release @Milanhe92 @viceice