Skip to content

fix(manager/poetry): set sourceName only if defined#32162

Merged
secustor merged 1 commit intorenovatebot:mainfrom
sisp:fix/poetry-set-sourcename-only-if-defined
Oct 27, 2024
Merged

fix(manager/poetry): set sourceName only if defined#32162
secustor merged 1 commit intorenovatebot:mainfrom
sisp:fix/poetry-set-sourcename-only-if-defined

Conversation

@sisp
Copy link
Copy Markdown
Contributor

@sisp sisp commented Oct 27, 2024

Changes

This is a minor internal fix that sets the managerData.sourceName property only if the source attribute in a dependency specification is set. Before, the property was always set, and it was set to undefined when the source attribute in a dependency specification was provided.

Context

See #32096 (comment) for the suggested change by @secustor.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested a review from secustor October 27, 2024 12:39
@secustor secustor added this pull request to the merge queue Oct 27, 2024
Merged via the queue into renovatebot:main with commit e0fb1de Oct 27, 2024
@sisp sisp deleted the fix/poetry-set-sourcename-only-if-defined branch October 27, 2024 14:01
@renovate-release
Copy link
Copy Markdown

🎉 This PR is included in version 38.132.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants