Skip to content

feat: add docker-socket-host-path input#862

Merged
viceice merged 3 commits intorenovatebot:mainfrom
justfalter:docker-socket-host-path
Sep 30, 2024
Merged

feat: add docker-socket-host-path input#862
viceice merged 3 commits intorenovatebot:mainfrom
justfalter:docker-socket-host-path

Conversation

@justfalter
Copy link
Copy Markdown
Contributor

@justfalter justfalter commented Aug 23, 2024

  • Adds docker-socket-host-path input, allowing users to override the location of the docker socket on their host. Defaults to /var/run/docker.sock.

src/input.ts Outdated
}

dockerSocketHostPath(): string {
return core.getInput('docker-socket-host-path');
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validate existence

src/renovate.ts Outdated
Comment on lines +87 to +88
const dockerSocketStat = await fs.stat(this.input.dockerSocketHostPath());
return dockerSocketStat.gid.toString();
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

separate PR

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this gets merged, I'll create a separate PR that leverages the stat done as part of verification to also get the gid.

- Adds `docker-socket-host-path` input, allowing users to override the
  location of the docker socket on their host. Defaults to
  `/var/run/docker.sock`.
@justfalter justfalter force-pushed the docker-socket-host-path branch from 8263fc6 to 328efab Compare August 24, 2024 13:29
@justfalter justfalter requested a review from viceice August 24, 2024 17:47
@justfalter
Copy link
Copy Markdown
Contributor Author

Any additional thoughts, @viceice?

@justfalter justfalter requested a review from viceice August 27, 2024 17:49
@viceice viceice enabled auto-merge (squash) September 30, 2024 10:22
@viceice viceice merged commit c0afe86 into renovatebot:main Sep 30, 2024
zemnmez-renovate-bot added a commit to zemn-me/monorepo that referenced this pull request Sep 30, 2024
github-merge-queue bot pushed a commit to zemn-me/monorepo that referenced this pull request Sep 30, 2024
zemnmez-renovate-bot added a commit to zemn-me/monorepo that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants