Skip to content

fix: support basename in static routers#9591

Merged
brophdawg11 merged 6 commits intodevfrom
brophdawg11/static-router-basename
Nov 23, 2022
Merged

fix: support basename in static routers#9591
brophdawg11 merged 6 commits intodevfrom
brophdawg11/static-router-basename

Conversation

@brophdawg11
Copy link
Copy Markdown
Contributor

@brophdawg11 brophdawg11 commented Nov 14, 2022 •
edited
Loading

Adds support for basename to static data routers. We accept it up front in createStaticHandler, and then persist it through createStaticRouter/StaticRouterPRovider

Sample usage:

let { query } = createStaticHandler(routes, { basename: '/base '});
let context = await query(request);
let router = createStaticRouter(routes, context);

return ReactDOMServer.renderToString(
  <StaticRouterProvider router={router} context={context} />
);

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Nov 14, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: e471d01

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
react-router-dom Patch
@remix-run/router Patch
react-router Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

brophdawg11
brophdawg11 commented Nov 14, 2022
View reviewed changes
Comment thread packages/react-router-dom/server.tsx
}

export interface StaticRouterProviderProps {
basename?: string;
Copy link
Copy Markdown
Contributor Author

@brophdawg11 brophdawg11 Nov 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To align with <RouterProvider> we no longer accept a basename as a prop, we inherit from the router passed to it. In the SSR case, that further inherits from the static handler.

@brophdawg11 brophdawg11 merged commit f9652c6 into dev Nov 23, 2022
@brophdawg11 brophdawg11 deleted the brophdawg11/static-router-basename branch November 23, 2022 20:39
This was referenced Nov 23, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacob-ebey jacob-ebey jacob-ebey approved these changes

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brophdawg11 @jacob-ebey @MichaelDeBoey